On Tue, Aug 14, 2018, 3:39 AM Aleksey Bekh-Ivanov < aleksey.bekh-ivanov@wikimedia.de> wrote:
Hi Brion.
I might be a bit late, but I just wonder why did you decide to go with forking instead of Pthreads PHP extension?
ForkController and OrderedStreamingForkController were already present and using pcntl_fork; also I didn't know PHP has a pthreads extension now. :) Worth looking at...
AFAIK, Mediawiki should support not only *nix platforms, but Windows as well, and `pcntl_fork()` does not work on Windows.
If no threads are specified it'll run in-process which will still work, but of course you get no additional processes then.
PS: Couldn't find related ticket. Can you post a link to it?
No ticket currently, though I can open one. :)
-- brion
Links: https://secure.php.net/manual/en/book.pthreads.php https://github.com/krakjoe/pthreads
Aleksey, Wikimedia Deutschland
On 13 August 2018 at 02:51, Brion Vibber bvibber@wikimedia.org wrote:
Thanks, looks like I misinterpreted the report output. :)
I think I can add a test case for ParallelMaintenance which should make
the
warning go away.
-- brion
On Sun, Aug 12, 2018, 1:51 PM Kunal Mehta legoktm@member.fsf.org
wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 08/11/2018 06:48 PM, Brion Vibber wrote:
Second, probably related to that I'm seeing a failure in the code coverage calculations -- it's seeing some increased coverage on the parent process at least but seems to think it's returning a non-zero exit code somewhere, which marks the whole operation as a failure:
https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-pa
tch-docker/460/console <https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-
patch-docker/460/console>
I
think your test and the tool are working properly, there just is an actual coverage drop:
+-------------------------------------+--------+--------+ | Filename | Old % | New % | +-------------------------------------+--------+--------+ | includes/QueueingForkController.php | 0 | 07.92 | | maintenance/Maintenance.php | 20.51 | 19.83 | +-------------------------------------+--------+--------+
If you look at the HTML report[1], all the new lines added to Maintenance.php are not covered by tests, which is decreasing coverage.
The tool currently reports a coverage drop if it drops in any file, which isn't necessary ideal, see [2].
[1]
https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-patc
h-docker/460/artifact/log/coverage.html <https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-
patch-docker/460/artifact/log/coverage.html>
[2] https://phabricator.wikimedia.org/T188687
- -- Legoktm
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAltwnZ4ACgkQUvyOe+23 /KIm8w//WZVvuCCxHlW2CmbKtw/hjiBCxTUsmFAdb4QCco2nJe1qcSKtU9tBWq0n HrT32rEK06sYSPFrcHE6KYCHYtaLAGn8zcpXTCnB15mq1c/yrkwNucXwpBbbs28b 776EjNzTnU8UbTP0y9qt+Z3g1rRAjFjbXSqbh/3Vi9nQDlgS+cCgMwudZ+INzCeV L0O+JKZKmfAswcSZbSVkWFDBQMZulhlP4ztS0hTYyixnGTl5z2Cc3c7F2OvjlcIx lyGZkh1544X6hG7t9t5o35Tjbwt/Y5de617QiiN6dvFO6OrxD/mNs17kp302WJS7 FjcPjFXvSsOdobG0Ff/cg8/cy1m5Ek6fctw1cCMWnYruy7rcYvt9QYz8NRxaSIES PdYmL8AiuY0173AKTTMgmOxjg0phY6Mrf7d8eo81zRwkENBjzwut2gEF6s4xeR6I jnKdqpHta6HWs3wF7+dTNxH8v5f7TRGVkz1PwacdbHZBj8PEUAge7789f2qqzByb V2P5tr/nMCTrIoc+iPsjif1AbQsbLk+dKs1BDHxymChnZa0gTIbUGnTriqKn4xIo qkZyflm66OHa+R6C3hcs5+OTfVnx7Sqqcmk3b7vC3N5ydlEwUXJSI9PrOC6xr77s ltUPh/8hsA3TLJ6CHyCwgnZtyZOL6XczysOHiWpBeH1wWhl+gwQ= =DSVw -----END PGP SIGNATURE-----
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l