On Mon, Jun 2, 2008 at 8:34 PM, Roan Kattouw
<roan.kattouw(a)home.nl> wrote:
Brion Vibber schreef:
At this point it probably makes sense to go ahead
and refactor this
check & transformation into Title::newFromText itself -- it's already
doing character reference decoding, so tossing in a URL decode doesn't
sound too out of bounds, and it'll keep behavior consistent.
I have the feeling that that'll spawn some nasty bugs relating to
pages
with literal "%28" etc. in them.
Roan Kattouw (Catrope)
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
I'm not sure what you mean with this? If done properly it should not
cause further breakage.
"If done properly" is the key sentence here.
We'd have to check *every*
call to Title::newFromText() (there are a lot of those), and the %28
corner case would probably still break in extensions who don't know
about the new behavior. Anyway, changing the behavior of a central class
such as Title is usually (usually) not a good idea.
Roan Kattouw (Catrope)