On Mon, 2012-08-27 at 17:59 +0000, Marcin Cieslak wrote:
When "need-review" should be removed?
If I understand it correctly: If the review takes place in Gerrit
anyway, then I don't see much sense in having this keyword in Bugzilla.
It should rather indicate something like "The attached patch needs be
moved to Gerrit so it can get a review in Gerrit".
I see only "patch-reviewed" in the keywords
- which can be
both negative and positive.
Apart from whether it makes sense to have this keyword if patch review
takes place in Gerrit anyway:
"patch-reviewed" obviously refers to a patch, while keywords refer to a
report. Hence using a keyword does not work well if a report includes
more than one patch.
This sounds like a classic usecase for a Bugzilla flag:
Set "review?" for requesting a review for a patch, get "review+" for
acceptance or "review-" for refusal.
Andre Klapper (maemo.org
bugmaster & GNOME Bugsquad)