On Fri, Mar 20, 2015 at 12:51 PM Bryan Davis <bd808(a)wikimedia.org> wrote:
The new PSR-3 debug logging system brought namespaced
external code
(Psr\Log\LoggerInterface) into use in MediaWiki core. The classes I
built out to work with this system are using faux namespaces by virtue
of class names like "MWLoggerFactory", "MWLoggerLegacyLogger" and
"MWLoggerMonologSyslogHandler". Before 1.25 starts rolling out as a
tarball release I'd like to change these classes to use actual PHP
namespaces rather than this clunky collision avoidance mechanism. [0]
There is also a task to backport minimal PSR-3 support to the 1.23 LTS
system to simplify backports of code and extensions that adopt direct
use of PSR-3 and I'd like to only do that once if possible.
Yay go for it imho :)
The color I have picked for this namespace bikeshed
is
MediaWiki\Core\Logger. The MediaWiki root namespace is a pretty
obvious choice. "Core" is inserted to distinguish this fundamental
MediaWiki functionality from any existing or future extensions that
might use namespaces. I'm hoping "Logger" is sufficiently distinct
from other uses of the term "log" in MediaWiki which generally mean
"audit trail" rather than "debugging information". I'd be fine
with
throwing Debug in between Core and Logger too if consensus found for
that instead.
MediaWiki\Core is a terrible name. Core is stupid and redundant
and it's a terrible pattern I hate having encouraged.
-Chad