On Tue, Jul 22, 2008 at 11:39 PM, sql@svn.wikimedia.org wrote:
'antispoof-name-conflict2' => '$1 $2','antispoof-name-conflict3' => '$1 $2 $3','antispoof-name-conflict4' => '$1 $2 $3 $4','antispoof-name-conflict5' => '$1 $2 $3 $4 $5',
What is the possible purpose of having a message here that solely consists of "$1 $2"? Do you want it to be customizable? Would there be any value whatsoever if an admin wanted to change that last message to "$5 $4 $3 $2 $1"? Just output the parameters one after another, in the code. You don't need to use a message, that makes no sense. Let alone with a switch statement rather than a loop.
Bryan probably makes a good point as well, although I didn't look at the output carefully to see further problems.