Besides, it adds much more overhead. What should we favour: readability or perfomance?
On Wed, May 15, 2013 at 11:43 PM, Tim Landscheidt tim@tim-landscheidt.dewrote:
Chris Steipp csteipp@wikimedia.org wrote:
[...]
It looks like we can define custom filters in twig, so we may be able to move the review to making sure the template correctly escapes the value for the context with the correct function. Something like:
<ul id="users"> {% for user in users %} <li><a href="{{ user|getMediaWikiUserURL }}">{{ users.name|e
}}</a></li>
{% endfor %}
[...]
So new MediaWiki developers would have to learn yet another syntax, debugging would require another level of indirec- tion, and if these custom filters include those we use for HTML5 now, the output would subtly differ from the template. What was the expected benefit of this operation again, and how often do we get to reap it? :-)
Tim
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l