On Wed, Aug 29, 2012 at 12:58 PM, Chad <innocentkiller(a)gmail.com> wrote:
Before I make the change though, I
wanted to ask about it publicly to make sure there's no major blockers
to me doing so.
As long as people that were previously able to push are still able to
+2 (which is probably true, unless the ACLs are really weird), and as
long as self-review isn't prevented by the software in the future
(there was some discussion about this at some point), I think this'll
be fine, because extension maintainers that used to use direct push
can submit their change for review, then approve it themselves.
I maintain that self-review is evil for core and deployed extensions,
but for undeployed extensions that don't have multiple active
maintainers I think it's fine.
Also, didn't Shawn say there were vague plans to make direct pushes
actually create changes and stuff? If and when that happens, I'd like
to open direct push back up, because really this self-review workflow
is a workaround for the fact that Gerrit doesn't handle direct pushes