Re: [Wikitech-l] Resource Loader messes up Leaflet CSS

Hey, When using the Maps extension together with MediaWiki 1.34 or later the markers on Leaflet maps do not show correctly. Example: https://user-images.githubusercontent.com/146040/78082503-7b1c1680-73b3-11e… Issue tread: https://github.com/JeroenDeDauw/Maps/issues/607 They show fine on older versions of MediaWiki. Though only if Maps loads the leaflet.css file by stuffing an Html::linkedStyle() into the header on top of using the Resouce Loader. Without that hack the bug also shows up on older MediaWiki versions. As you can deduce from that hack working, Resouce Loader is somehow involved. This can be confirmed by setting $wgResourceLoaderDebug to true, which causes the bug to disappear. I tracked this down a bit and found that this modification "fixes" the bug as well: https://github.com/JeroenDeDauw/MediaWiki/commit/1713ccde9de7d59634b1a134c5… Without knowing how the Leaflet library is being broken or knowing Resource Loader internals, this is rather hard to track down further. Any help is much appreciated. Some relevant code: * Resource loader module definition: https://github.com/JeroenDeDauw/Maps/blob/master/extension.json#L111 * leaflet.css: https://github.com/JeroenDeDauw/Maps/blob/master/resources/lib/leaflet/leaf… Cheers -- Jeroen De Dauw | www.EntropyWins.wtf <https://EntropyWins.wtf> Professional wiki hosting and services: www.Professional.Wiki <https://Professional.Wiki> Entrepreneur | Software Crafter | Open Source | Wikimedia | Speaker ~=[,,_,,]:3 _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l