On Sat, May 7, 2011 at 4:02 AM, Ryan Lane rlane32@gmail.com wrote:
On Fri, May 6, 2011 at 10:56 AM, Trevor Parscal tparscal@wikimedia.org wrote:
Moving WikiEditor into core would involve...
Straightforward changes
- Move the contents of the WikiEditor modules folder to resources/jquery.wikiEditor/ and resources/wikiEditor (removing the "ext." from files that have it) - Move the module registrations to resources/Resources.php - Distribute messages in WikiEditor.i18n.php into core message files - Move configurations in WikiEditor.php to DefaultSettings.php
Messy changes
- Put the logic for adding preferences somewhere - Put the logic for adding modules to edit pages based on preferences somewhere
This results in the WikiEditor code no longer being all in one place. I have always thought that was a downside.
Why don't we have a modules system, where extensions are simply integrated as is into core? Basically, extensions that are found to be essential for MediaWiki could be moved from /extensions to /modules, only needing to change small portions of code to fix references to the directory.
I like this idea a lot. It keeps our main code paths clean (if not awfully easy to follow), and simplifies merging extensions into core.
-- Andrew Garrett Wikimedia Foundation agarrett@wikimedia.org