On 10-12-27 09:40 AM, Aryeh Gregor wrote:
On Mon, Dec 27, 2010 at 9:02 AM, Daniel Friesen
<lists(a)nadir-seen-fire.com> wrote:
The effects will be like this:
- The three content_actions related hooks will no longer work in 1.18,
thus extensions that haven't started supporting vector tabs will also
stop showing tabs in other skins
- In their place extensions will use 3 navigation_urls related hooks
(most extensions are already using the one hook available)
If it wouldn't be
too much extra work, it would be preferable to keep
back-compat for the content_actions hooks -- have the code rewrite any
changes to content_actions to comparable changes to navigation_urls.
But only if it's not too messy (I haven't looked at the code). Other
than that, I'm entirely in favor of harmonizing the skin
implementations.
While writing that e-mail I did contemplate an idea on how the old
content_actions hooks could potentially just be given a single category
and say drop tabs into an "other" category.
But then I made a few realizations. Firstly, an "other" category will
not work nicely with vector's grouping of tabs... Secondly, restricting
to any specific category will not be compatible with hooks trying to
remove from another category. But worst of all... because extensions
want to maintain backwards compatibility for awhile, the extensions that
are right now trying to be backwards and forwards compatible (the way we
want them to be), or rather actually work in both monobook and vector
class skins will start inserting duplicate tabs into the page if we do
something like that.
It really shouldn't be too hard to take any implementation using
content_actions hooks and make them work with navigation_urls hooks
(once we add the two missing hooks) since they're really the same hooks,
with the same data, the only difference is with the navigation_urls
hooks you use something like $nav_urls["actions"][...] instead of
$content_actions[...] for your code... so it's really just copying the
code, deciding which category the tab belongs in, and making minor tweaks.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [
http://daniel.friesen.name]