On 8/28/07, Rob Church <robchur(a)gmail.com> wrote:
Note the comments on the bug; in particular,
http://bugzilla.wikimedia.org/show_bug.cgi?id=8753#c2 - this is an
example of a bug where it's not clear whether there is a problem to
solve.
Those comments really related to the first patch which applied
nofollow to all interwiki links; the second patch allowed nofollow to
be applied only to non-local links. This would have allowed what was
more or less the consensus position as I read it after the long
discussions about nofollow and interwiki links through March, April
and May on Wikien-l.
This message from Anthere was a pretty good statement of what was agreed on:
http://lists.wikimedia.org/pipermail/wikien-l/2007-May/070291.html
The patch does avoid the need for a whitelist by using the existing
"local" property on interwikis.
Have you run an EXPLAIN SELECT and checked the
performance of the
modified queries?
No, for the reasons Yuri mentions (internet broadly sucks in Australia
and I can't afford to download any really useful data, plus I run
MySQL 5). I thought about doing one on the toolserver but apparently
that runs MySQL 5 too.
The query is, however, almost exactly the same as the existing one, it
just uses a different (existing, but apparently unused) index on the
table. The performance should be the same.
--
Stephen Bain
stephen.bain(a)gmail.com