That works for me, I'm just curious what changed your mind (from the definition of #699 we hammered out together).  It really is no big deal either way though.

On Friday, October 25, 2013, Dario Taraborelli wrote:

Steven's point goes back to a suggestion I made a while ago: we need to avoid a many-to-many relation between metrics and aggregators. 

Each metric should return just values of one type (e.g. no mixing of booleans and integers, like threshold and time to threshold) and we should specify for each metric : (1) what the expected type of the output is and (2) what aggregators are appropriate for that type.

Practically, we can group metrics into categories depending on the attribute they compute:

• binary attributes (e.g. "got reverted", "got blocked", "is productive", "hit threshold")

• counts ("bytes added", "pages created", "time to threshold")

• rates ("revert rate")

Each of these attributes will have a canonical type:

• boolean for binary attributes

• integer for counts

• float for rates

We can then specify what aggregator is valid as a function of the metric category/type.

How does that sound?

Dario

On Oct 25, 2013, at 2:16 PM, Diederik van Liere <dvanliere@wikimedia.org> wrote:

On Fri, Oct 25, 2013 at 2:07 PM, Steven Walling <swalling@wikimedia.org> wrote:

Hey all, 

I used the threshold metric for the first time yesterday. First off, thanks for adding it! Dario tells me it was brand new as of yesterday? He also said it needs vetting?

Yes it needs extra vetting! 

One piece of feedback: combining threshold and 'time to threshold' seems to make things more confusing. For example, when you select sum as an output, you also get the sum of the time to threshold. That result -- like "time_to_threshold": 92.7864 -- seems to be simply the sum of hours for the members of the cohort. Knowing that it took the cohort a combined 92 hours to reach the threshold isn't very actionable.

So.......what are you proposing? separating it as two separate metrics? 

--

Steven Walling,

Product Manager

https://wikimediafoundation.org/

_______________________________________________
Wikimetrics mailing list
Wikimetrics@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikimetrics

_______________________________________________
Wikimetrics mailing list
Wikimetrics@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikimetrics

_______________________________________________
Wikimetrics mailing list
Wikimetrics@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikimetrics