Hey,
I have some questions/remarks on the "Complete Datamodel in WON" section Markus wrote up yesterday: https://meta.wikimedia.org/wiki/Wikidata/Data_model#Complete_Datamodel_in_WON
There are several things we have not modelled yet, which I'm currently not going to comment on. For those we did already implement or thought about implementing, there are a few things that do not match what's written in this section.
> SiteLanguageCode
All occurrences of this should be replaced by GlobalSiteIdentifier, as it's NOT a language code.
> ItemDescription := 'ItemDescription(' Item {TitleRecord} [MultilingualTextValue] [MultilingualTextValue] {Statement} ')'
This is missing the aliases stuff, which would be { UserLanguageCode String }.
> GeoCoordinatesValue := 'GeoCoordinatesValue(' decimal decimal decimal ')'
Altitude is probably something we will not have in many cases, so I think this ought to be optional. Another optional argument would be the globe to which the coordinates belong. Different globes have different ways of measuring coordinates, so a specific set of coordinates that is valid on one might mean something else on another and simply be invalid on a third.
> PropertyDescription := 'PropertyDescription(' Property {TitleRecord} [MultilingualTextValue] [MultilingualTextValue] ')'
Right now the Property interface is very similar to the Item one, except that Item has what we're calling sitelinks (in the here discussed WON it's called TitleRecords), and property does not. That's the first difference. Copy paste error? Or am I misinterpreting the notation?
As with Item, it's missing the aliases.
Although we have not implemented this yet, the Entity interface implies that it contains a list of statements. I added this after some discussion with Denny. As a result, both Items and Properties have a list of statements. That's the third difference with the WON stuff. Here the question is if non-Item Entities should have statements or not. There is no consensus on this within the team yet, so I will start a new thread about it so we can discuss it in more detail.
Cheers
--
Jeroen De Dauw
http://www.bn2vs.com
Don't panic. Don't be evil.
--