Hey, I sat down with Denny today and we had a look over the QueryEngine component code. It however still needs a more formal review. Current unreviewed code is sitting on the sqlstore feature branch. Difference with master: https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/master..… This branch currently contains two commits [0, 1] that I made against master for non QueryEngine improvements that where needed to get the tests for the QueryEngine component to run on their own. So it'd be good to have these reviewed first, then merge master into sqlstore, and no longer have them in the diff there. [0] https://gerrit.wikimedia.org/r/#/c/63218/ [1] https://gerrit.wikimedia.org/r/#/c/63219/ Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --