I just noticed this commit [0], which gets rid of a pile of direct BasicEntityIdParser usages for performance reasons.
It also addresses a problem which is apparently more widespread than I thought: using an EntityIdParser that only works for Item IDs and Property IDs. Unless you are only dealing with Item IDs or with Property IDs, an EntityIdParser should always be injected. This allows the thing constructing the object graph to add support for all required entity types, and gives extensions to Wikibase Repo (or Wikibase Client) a chance to register new entity types.
Of course this also means that no new code that introduces such occurrences should be allowed through review, even if it contains a "fix this later" TODO (for new code there is no excuse to do it wrong).
Software craftsmanship advocate
Evil software architect at Wikimedia Germany
~=[,,_,,]:3