| UNSTABLE: operations-puppet-wmf-style-guide Build #467 (Wed, 22 Nov 2017 18:10:03 +0000) |
No changes
[...truncated 274.57 KB...] modules/role/manifests/toollabs/logging/sender.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::logging::sender' should declare system::role once modules/role/manifests/toollabs/logging/sender.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::logging::sender' should not include defines modules/role/manifests/toollabs/mailrelay.pp:5:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::mailrelay' includes toollabs::mailrelay which is neither a role nor a profile modules/role/manifests/toollabs/master.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::master' includes toollabs::master which is neither a role nor a profile modules/role/manifests/toollabs/node/compute/dedicated.pp:16:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::compute::dedicated' includes toollabs::node::all which is neither a role nor a profile modules/role/manifests/toollabs/node/compute/dedicated.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::compute::dedicated' should declare system::role once modules/role/manifests/toollabs/node/compute/dedicated.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::compute::dedicated' should not include defines modules/role/manifests/toollabs/node/compute/general.pp:16:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::compute::general' includes toollabs::node::all which is neither a role nor a profile modules/role/manifests/toollabs/node/compute/general.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::compute::general' should not include defines modules/role/manifests/toollabs/node/web.pp:18:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web' includes toollabs::node::all which is neither a role nor a profile modules/role/manifests/toollabs/node/web.pp:19:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web' includes gridengine::submit_host which is neither a role nor a profile modules/role/manifests/toollabs/node/web.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web' should declare system::role once modules/role/manifests/toollabs/node/web.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web' should not include defines modules/role/manifests/toollabs/node/web/generic.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web::generic' should declare system::role once modules/role/manifests/toollabs/node/web/generic.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web::generic' should not include defines modules/role/manifests/toollabs/node/web/lighttpd.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web::lighttpd' should declare system::role once modules/role/manifests/toollabs/node/web/lighttpd.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::node::web::lighttpd' should not include defines modules/role/manifests/toollabs/proxy.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::proxy' includes toollabs::proxy which is neither a role nor a profile modules/role/manifests/toollabs/proxy.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::proxy' should not include defines modules/role/manifests/toollabs/puppet/master.pp:2:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::puppet::master' includes toollabs::infrastructure which is neither a role nor a profile modules/role/manifests/toollabs/puppet/master.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::puppet::master' includes toollabs::puppetmaster which is neither a role nor a profile modules/role/manifests/toollabs/puppet/master.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::puppet::master' should declare system::role once modules/role/manifests/toollabs/redis.pp:8:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::redis' includes toollabs::redis which is neither a role nor a profile modules/role/manifests/toollabs/static.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::toollabs::static' includes toollabs::static which is neither a role nor a profile modules/role/manifests/torrus.pp:2:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' includes torrus which is neither a role nor a profile modules/role/manifests/torrus.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' includes torrus::web which is neither a role nor a profile modules/role/manifests/torrus.pp:4:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' includes torrus::xml_generation::cdn which is neither a role nor a profile modules/role/manifests/torrus.pp:5:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' includes passwords::network which is neither a role nor a profile modules/role/manifests/torrus.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' should declare system::role once modules/role/manifests/torrus.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::torrus' should not include defines modules/role/manifests/wdq_mm/lb.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wdq_mm::lb' should declare system::role once modules/role/manifests/wdq_mm/server.pp:9:wmf_styleguide:ERROR:wmf-style: role 'role::wdq_mm::server' includes labs_debrepo which is neither a role nor a profile modules/role/manifests/wdq_mm/server.pp:11:wmf_styleguide:ERROR:wmf-style: role 'role::wdq_mm::server' includes labs_lvm which is neither a role nor a profile modules/role/manifests/wdq_mm/server.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wdq_mm::server' should declare system::role once modules/role/manifests/wdq_mm/server.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wdq_mm::server' should not include defines modules/role/manifests/wdqs.pp:6:wmf_styleguide:ERROR:wmf-style: role 'role::wdqs' includes base::firewall which is neither a role nor a profile modules/role/manifests/wdqs/labs.pp:10:wmf_styleguide:ERROR:wmf-style: role 'role::wdqs::labs' includes base::firewall which is neither a role nor a profile modules/role/manifests/webperf.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::webperf' should declare system::role once modules/role/manifests/webserver_misc_static.pp:7:wmf_styleguide:ERROR:wmf-style: role 'role::webserver_misc_static' includes apache which is neither a role nor a profile modules/role/manifests/webserver_misc_static.pp:8:wmf_styleguide:ERROR:wmf-style: role 'role::webserver_misc_static' includes apache::mod::authnz_ldap which is neither a role nor a profile modules/role/manifests/webserver_misc_static.pp:9:wmf_styleguide:ERROR:wmf-style: role 'role::webserver_misc_static' includes apache::mod::rewrite which is neither a role nor a profile modules/role/manifests/webserver_misc_static.pp:10:wmf_styleguide:ERROR:wmf-style: role 'role::webserver_misc_static' includes apache::mod::headers which is neither a role nor a profile modules/role/manifests/wikidata/builder.pp:3:wmf_styleguide:ERROR:wmf-style: role 'role::wikidata::builder' includes wikidatabuilder which is neither a role nor a profile modules/role/manifests/wikidata/builder.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wikidata::builder' should declare system::role once modules/role/manifests/wikilabels/server.pp:7:wmf_styleguide:ERROR:wmf-style: role 'role::wikilabels::server' includes wikilabels::session which is neither a role nor a profile modules/role/manifests/wikilabels/server.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wikilabels::server' should declare system::role once modules/role/manifests/wikilabels/staging.pp:7:wmf_styleguide:ERROR:wmf-style: role 'role::wikilabels::staging' includes wikilabels::session which is neither a role nor a profile modules/role/manifests/wikilabels/staging.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wikilabels::staging' should declare system::role once modules/role/manifests/wikimetrics/production.pp:6:wmf_styleguide:ERROR:wmf-style: role 'role::wikimetrics::production' includes wikimetrics::base which is neither a role nor a profile modules/role/manifests/wikimetrics/production.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wikimetrics::production' should declare system::role once modules/role/manifests/wikimetrics/staging.pp:6:wmf_styleguide:ERROR:wmf-style: role 'role::wikimetrics::staging' includes wikimetrics::base which is neither a role nor a profile modules/role/manifests/wikimetrics/staging.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::wikimetrics::staging' should declare system::role once modules/role/manifests/xenon.pp:7:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' includes xenon which is neither a role nor a profile modules/role/manifests/xenon.pp:9:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' includes apache::mod::mime which is neither a role nor a profile modules/role/manifests/xenon.pp:10:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' includes apache::mod::proxy which is neither a role nor a profile modules/role/manifests/xenon.pp:11:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' includes apache::mod::proxy_http which is neither a role nor a profile modules/role/manifests/xenon.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' should declare system::role once modules/role/manifests/xenon.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::xenon' should not include defines modules/role/manifests/xhgui/app.pp:21:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' includes apache::mod::authnz_ldap which is neither a role nor a profile modules/role/manifests/xhgui/app.pp:22:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' includes apache::mod::php5 which is neither a role nor a profile modules/role/manifests/xhgui/app.pp:23:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' includes apache::mod::rewrite which is neither a role nor a profile modules/role/manifests/xhgui/app.pp:25:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' includes mongodb which is neither a role nor a profile modules/role/manifests/xhgui/app.pp:27:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' includes passwords::ldap::production which is neither a role nor a profile modules/role/manifests/xhgui/app.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::xhgui::app' should not include defines modules/role/manifests/zotero.pp:22:wmf_styleguide:ERROR:wmf-style: role 'role::zotero' includes zotero which is neither a role nor a profile modules/role/manifests/zotero.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::zotero' should not include defines modules/scap/manifests/conftool.pp:7:wmf_styleguide:ERROR:wmf-style: class 'scap::conftool' includes conftool::scripts from another module modules/scap/manifests/dsh/group.pp:12:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'scap::dsh::group' for 'scap::dsh::' modules/scap/manifests/l10nupdate.pp:16:wmf_styleguide:ERROR:wmf-style: class 'scap::l10nupdate' includes mediawiki::users from another module modules/scap/manifests/master.pp:56:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'scap::master' for 'scap::deployment_server' modules/scap/manifests/master.pp:14:wmf_styleguide:ERROR:wmf-style: class 'scap::master' includes rsync::server from another module modules/scap/manifests/master.pp:15:wmf_styleguide:ERROR:wmf-style: class 'scap::master' includes network::constants from another module modules/scap/manifests/master.pp:16:wmf_styleguide:ERROR:wmf-style: class 'scap::master' includes mediawiki::scap from another module modules/scap/manifests/scripts.pp:10:wmf_styleguide:ERROR:wmf-style: class 'scap::scripts' includes mediawiki::users from another module modules/scap/manifests/source.pp:127:wmf_styleguide:ERROR:wmf-style: defined type 'scap::source' includes lvs::configuration from another module modules/scap/manifests/target.pp:104:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'scap::target' for 'scap::deployment_server' modules/sentry/manifests/init.pp:34:wmf_styleguide:ERROR:wmf-style: class 'sentry' includes nginx from another module modules/sentry/manifests/init.pp:35:wmf_styleguide:ERROR:wmf-style: class 'sentry' includes nginx::ssl from another module modules/sentry/manifests/init.pp:36:wmf_styleguide:ERROR:wmf-style: class 'sentry' includes postgresql::server from another module modules/service/manifests/node.pp:177:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'service::node' for 'contactgroups' modules/service/manifests/node.pp:190:wmf_styleguide:ERROR:wmf-style: defined type 'service::node' includes scap::conftool from another module modules/service/manifests/uwsgi.pp:93:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'service::uwsgi' for 'contactgroups' modules/shinken/manifests/init.pp:73:wmf_styleguide:ERROR:wmf-style: class 'shinken' declares class nagios_common::contactgroups from another module modules/shinken/manifests/init.pp:82:wmf_styleguide:ERROR:wmf-style: class 'shinken' declares class nagios_common::contacts from another module modules/shinken/manifests/init.pp:91:wmf_styleguide:ERROR:wmf-style: class 'shinken' declares class [ from another module modules/shinken/manifests/init.pp:102:wmf_styleguide:ERROR:wmf-style: class 'shinken' declares class nagios_common::notification_commands from another module modules/shinken/manifests/init.pp:119:wmf_styleguide:ERROR:wmf-style: class 'shinken' declares class nagios_common::commands from another module modules/shinken/manifests/ircbot.pp:36:wmf_styleguide:ERROR:wmf-style: class 'shinken::ircbot' declares class ircecho from another module modules/shiny_server/manifests/init.pp:22:wmf_styleguide:ERROR:wmf-style: class 'shiny_server' declares class r_lang from another module modules/smokeping/manifests/web.pp:9:wmf_styleguide:ERROR:wmf-style: class 'smokeping::web' includes apache::mod::fcgid from another module modules/smokeping/manifests/web.pp:10:wmf_styleguide:ERROR:wmf-style: class 'smokeping::web' includes apache::mod::rewrite from another module modules/smokeping/manifests/web.pp:11:wmf_styleguide:ERROR:wmf-style: class 'smokeping::web' includes apache::mod::headers from another module modules/snapshot/manifests/dumps/cron.pp:12:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'snapshot::dumps::cron' for 'snapshot::dumps::maxjobs' modules/snapshot/manifests/dumps/cron.pp:31:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'snapshot::dumps::cron' for 'snapshot::dumps::runtype' modules/ssh/manifests/server.pp:40:wmf_styleguide:ERROR:wmf-style: class 'ssh::server' includes network::constants from another module modules/sslcert/manifests/init.pp:54:wmf_styleguide:ERROR:wmf-style: class 'sslcert' includes apparmor from another module modules/standard/manifests/diamond.pp:22:wmf_styleguide:ERROR:wmf-style: class 'standard::diamond' declares class diamond from another module modules/standard/manifests/init.pp:9:wmf_styleguide:ERROR:wmf-style: class 'standard' includes profile::base from another module modules/standard/manifests/init.pp:13:wmf_styleguide:ERROR:wmf-style: class 'standard' includes profile::cumin::target from another module modules/standard/manifests/init.pp:28:wmf_styleguide:ERROR:wmf-style: class 'standard' includes ganglia from another module modules/standard/manifests/init.pp:30:wmf_styleguide:ERROR:wmf-style: class 'standard' includes ganglia::monitor::decommission from another module modules/standard/manifests/init.pp:42:wmf_styleguide:ERROR:wmf-style: class 'standard' includes admin from another module modules/standard/manifests/mail/sender.pp:2:wmf_styleguide:ERROR:wmf-style: class 'standard::mail::sender' declares class exim4 from another module modules/standard/manifests/ntp.pp:5:wmf_styleguide:ERROR:wmf-style: class 'standard::ntp' includes network::constants from another module modules/standard/manifests/prometheus.pp:3:wmf_styleguide:ERROR:wmf-style: class 'standard::prometheus' includes role::prometheus::node_exporter from another module modules/statistics/manifests/compute.pp:72:wmf_styleguide:ERROR:wmf-style: class 'statistics::compute' includes passwords::mysql::research from another module modules/statistics/manifests/discovery.pp:5:wmf_styleguide:ERROR:wmf-style: class 'statistics::discovery' includes passwords::mysql::research from another module modules/statistics/manifests/mysql_credentials.pp:7:wmf_styleguide:ERROR:wmf-style: defined type 'statistics::mysql_credentials' includes passwords::mysql::research from another module modules/statistics/manifests/packages.pp:4:wmf_styleguide:ERROR:wmf-style: class 'statistics::packages' includes geoip from another module modules/statistics/manifests/packages.pp:5:wmf_styleguide:ERROR:wmf-style: class 'statistics::packages' includes imagemagick::install from another module modules/statistics/manifests/packages.pp:159:wmf_styleguide:ERROR:wmf-style: class 'statistics::packages' includes r_lang from another module modules/statistics/manifests/rsyncd.pp:16:wmf_styleguide:ERROR:wmf-style: class 'statistics::rsyncd' declares class rsync::server from another module modules/statistics/manifests/sites/analytics.pp:49:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::analytics' includes apache::mod::headers from another module modules/statistics/manifests/sites/analytics.pp:52:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::analytics' includes apache::mod::rewrite from another module modules/statistics/manifests/sites/hue.pp:11:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::hue' includes apache::mod::proxy_http from another module modules/statistics/manifests/sites/hue.pp:12:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::hue' includes apache::mod::proxy from another module modules/statistics/manifests/sites/metrics.pp:8:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::metrics' includes apache::mod::alias from another module modules/statistics/manifests/sites/pivot.pp:26:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::pivot' includes apache::mod::proxy_http from another module modules/statistics/manifests/sites/pivot.pp:27:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::pivot' includes apache::mod::proxy from another module modules/statistics/manifests/sites/pivot.pp:28:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::pivot' includes apache::mod::auth_basic from another module modules/statistics/manifests/sites/pivot.pp:29:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::pivot' includes apache::mod::authnz_ldap from another module modules/statistics/manifests/sites/pivot.pp:30:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::pivot' includes passwords::ldap::production from another module modules/statistics/manifests/sites/stats.pp:18:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::stats' includes geowiki::private_data from another module modules/statistics/manifests/sites/stats.pp:15:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::stats' declares class geowiki from another module modules/statistics/manifests/sites/yarn.pp:12:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::proxy_http from another module modules/statistics/manifests/sites/yarn.pp:13:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::proxy from another module modules/statistics/manifests/sites/yarn.pp:14:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::proxy_html from another module modules/statistics/manifests/sites/yarn.pp:15:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::xml2enc from another module modules/statistics/manifests/sites/yarn.pp:16:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::auth_basic from another module modules/statistics/manifests/sites/yarn.pp:17:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes apache::mod::authnz_ldap from another module modules/statistics/manifests/sites/yarn.pp:18:wmf_styleguide:ERROR:wmf-style: class 'statistics::sites::yarn' includes passwords::ldap::production from another module modules/statistics/manifests/user.pp:2:wmf_styleguide:ERROR:wmf-style: class 'statistics::user' includes passwords::statistics::user from another module modules/statistics/manifests/web.pp:37:wmf_styleguide:ERROR:wmf-style: class 'statistics::web' includes apache::mod::rewrite from another module modules/statistics/manifests/web.pp:38:wmf_styleguide:ERROR:wmf-style: class 'statistics::web' includes apache::mod::proxy from another module modules/statistics/manifests/web.pp:39:wmf_styleguide:ERROR:wmf-style: class 'statistics::web' includes apache::mod::proxy_http from another module modules/statistics/manifests/web.pp:40:wmf_styleguide:ERROR:wmf-style: class 'statistics::web' includes apache::mod::headers from another module modules/statistics/manifests/web.pp:41:wmf_styleguide:ERROR:wmf-style: class 'statistics::web' includes apache::mod::cgi from another module modules/statistics/manifests/wmde/graphite.pp:37:wmf_styleguide:ERROR:wmf-style: class 'statistics::wmde::graphite' includes passwords::mysql::research from another module modules/statsite/manifests/instance.pp:24:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'statsite::instance' for 'statsite::instance::graphite_host' modules/statsite/manifests/instance.pp:25:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'statsite::instance' for 'statsite::instance::graphite_port' modules/statsite/manifests/instance.pp:27:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'statsite::instance' for 'statsite::instance::extended_counters' modules/striker/manifests/apache.pp:22:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache from another module modules/striker/manifests/apache.pp:23:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::expires from another module modules/striker/manifests/apache.pp:24:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::headers from another module modules/striker/manifests/apache.pp:25:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::lbmethod_byrequests from another module modules/striker/manifests/apache.pp:26:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::proxy from another module modules/striker/manifests/apache.pp:27:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::proxy_balancer from another module modules/striker/manifests/apache.pp:28:wmf_styleguide:ERROR:wmf-style: class 'striker::apache' includes apache::mod::proxy_http from another module modules/striker/manifests/uwsgi.pp:33:wmf_styleguide:ERROR:wmf-style: class 'striker::uwsgi' includes service::configuration from another module modules/swift/manifests/storage.pp:15:wmf_styleguide:ERROR:wmf-style: class 'swift::storage' declares class rsync::server from another module modules/swift/manifests/storage/monitor_swift_daemon.pp:2:wmf_styleguide:ERROR:wmf-style: defined type 'swift::storage::monitor_swift_daemon' includes nrpe from another module modules/swift/manifests/storage/monitoring.pp:2:wmf_styleguide:ERROR:wmf-style: class 'swift::storage::monitoring' includes nrpe from another module modules/tendril/manifests/init.pp:13:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes passwords::ldap::wmf_cluster from another module modules/tendril/manifests/init.pp:14:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes passwords::tendril from another module modules/tendril/manifests/init.pp:21:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes apache::mod::rewrite from another module modules/tendril/manifests/init.pp:22:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes apache::mod::headers from another module modules/tendril/manifests/init.pp:23:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes apache::mod::ssl from another module modules/tendril/manifests/init.pp:24:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes apache::mod::php5 from another module modules/tendril/manifests/init.pp:25:wmf_styleguide:ERROR:wmf-style: class 'tendril' includes apache::mod::authnz_ldap from another module modules/thumbor/manifests/nutcracker.pp:13:wmf_styleguide:ERROR:wmf-style: class 'thumbor::nutcracker' includes nutcracker::monitoring from another module modules/thumbor/manifests/nutcracker.pp:30:wmf_styleguide:ERROR:wmf-style: class 'thumbor::nutcracker' declares class nutcracker from another module modules/tlsproxy/manifests/instance.pp:19:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'tlsproxy::instance' for 'cache::websocket_support' modules/tlsproxy/manifests/instance.pp:20:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'tlsproxy::instance' for 'cache::lua_support' modules/tlsproxy/manifests/instance.pp:23:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'tlsproxy::instance' for 'cache::tune_for_media' modules/tlsproxy/manifests/instance.pp:24:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'tlsproxy::instance' for 'tlsproxy::nginx_client_max_body_size' modules/tlsproxy/manifests/instance.pp:36:wmf_styleguide:ERROR:wmf-style: class 'tlsproxy::instance' declares class nginx from another module modules/tlsproxy/manifests/localssl.pp:71:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'tlsproxy::localssl' for 'cache::websocket_support' modules/tlsproxy/manifests/localssl.pp:72:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'tlsproxy::localssl' for 'tlsproxy::localssl::proxy_request_buffering' modules/tlsproxy/manifests/localssl.pp:75:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'tlsproxy::localssl' for 'tlsproxy::localssl::fastopen_pending_max' modules/tlsproxy/manifests/prometheus.pp:4:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'tlsproxy::prometheus' for 'prometheus_nodes' modules/toollabs/manifests/bastion.pp:212:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::bastion' for 'active_cronrunner' modules/toollabs/manifests/bastion.pp:11:wmf_styleguide:ERROR:wmf-style: class 'toollabs::bastion' includes gridengine::admin_host from another module modules/toollabs/manifests/bastion.pp:12:wmf_styleguide:ERROR:wmf-style: class 'toollabs::bastion' includes gridengine::submit_host from another module modules/toollabs/manifests/bastion.pp:204:wmf_styleguide:ERROR:wmf-style: class 'toollabs::bastion' includes ldap::role::config::labs from another module modules/toollabs/manifests/checker.pp:10:wmf_styleguide:ERROR:wmf-style: class 'toollabs::checker' includes gridengine::submit_host from another module modules/toollabs/manifests/compute.pp:9:wmf_styleguide:ERROR:wmf-style: class 'toollabs::compute' includes gridengine from another module modules/toollabs/manifests/cronrunner.pp:8:wmf_styleguide:ERROR:wmf-style: class 'toollabs::cronrunner' includes gridengine::submit_host from another module modules/toollabs/manifests/dev_environ.pp:14:wmf_styleguide:ERROR:wmf-style: class 'toollabs::dev_environ' includes phabricator::arcanist from another module modules/toollabs/manifests/dev_environ.pp:29:wmf_styleguide:ERROR:wmf-style: class 'toollabs::dev_environ' includes phabricator::arcanist from another module modules/toollabs/manifests/exec_environ.pp:10:wmf_styleguide:ERROR:wmf-style: class 'toollabs::exec_environ' includes locales::extended from another module modules/toollabs/manifests/exec_environ.pp:11:wmf_styleguide:ERROR:wmf-style: class 'toollabs::exec_environ' includes identd from another module modules/toollabs/manifests/exec_environ.pp:12:wmf_styleguide:ERROR:wmf-style: class 'toollabs::exec_environ' includes redis::client::python from another module modules/toollabs/manifests/exec_environ.pp:13:wmf_styleguide:ERROR:wmf-style: class 'toollabs::exec_environ' includes mediawiki::packages::fonts from another module modules/toollabs/manifests/exec_environ.pp:16:wmf_styleguide:ERROR:wmf-style: class 'toollabs::exec_environ' includes imagemagick::install from another module modules/toollabs/manifests/images.pp:5:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::images' for 'docker::registry' modules/toollabs/manifests/images.pp:4:wmf_styleguide:ERROR:wmf-style: class 'toollabs::images' declares class docker::baseimages from another module modules/toollabs/manifests/init.pp:149:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs' for 'active_proxy_host' modules/toollabs/manifests/init.pp:158:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs' for 'active_redis' modules/toollabs/manifests/init.pp:11:wmf_styleguide:ERROR:wmf-style: class 'toollabs' includes labs_lvm from another module modules/toollabs/manifests/init.pp:127:wmf_styleguide:ERROR:wmf-style: class 'toollabs' declares class exim4 from another module modules/toollabs/manifests/kube2proxy.pp:29:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::kube2proxy' for 'active_proxy_host' modules/toollabs/manifests/kube2proxy.pp:36:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::kube2proxy' for 'k8s_infrastructure_users' modules/toollabs/manifests/mailrelay.pp:17:wmf_styleguide:ERROR:wmf-style: class 'toollabs::mailrelay' includes gridengine::submit_host from another module modules/toollabs/manifests/mailrelay.pp:20:wmf_styleguide:ERROR:wmf-style: class 'toollabs::mailrelay' declares class exim4 from another module modules/toollabs/manifests/master.pp:5:wmf_styleguide:ERROR:wmf-style: class 'toollabs::master' includes gridengine::master from another module modules/toollabs/manifests/proxy.pp:20:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::proxy' for 'active_proxy_host' modules/toollabs/manifests/proxy.pp:11:wmf_styleguide:ERROR:wmf-style: class 'toollabs::proxy' includes redis::client::python from another module modules/toollabs/manifests/proxy.pp:12:wmf_styleguide:ERROR:wmf-style: class 'toollabs::proxy' includes base::firewall from another module modules/toollabs/manifests/proxy.pp:30:wmf_styleguide:ERROR:wmf-style: class 'toollabs::proxy' declares class dynamicproxy from another module modules/toollabs/manifests/puppetmaster.pp:5:wmf_styleguide:ERROR:wmf-style: class 'toollabs::puppetmaster' declares class puppet::self::master from another module modules/toollabs/manifests/puppetmaster.pp:10:wmf_styleguide:ERROR:wmf-style: class 'toollabs::puppetmaster' declares class puppetmaster::gitsync from another module modules/toollabs/manifests/redis.pp:23:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'toollabs::redis' for 'active_redis' modules/toollabs/manifests/redis.pp:11:wmf_styleguide:ERROR:wmf-style: class 'toollabs::redis' includes redis::client::python from another module modules/toollabs/manifests/redis.pp:12:wmf_styleguide:ERROR:wmf-style: class 'toollabs::redis' includes labs_lvm from another module modules/toollabs/manifests/services.pp:13:wmf_styleguide:ERROR:wmf-style: class 'toollabs::services' includes gridengine::submit_host from another module modules/toollabs/manifests/shadow.pp:10:wmf_styleguide:ERROR:wmf-style: class 'toollabs::shadow' declares class gridengine::shadow_master from another module modules/toolserver_legacy/manifests/init.pp:9:wmf_styleguide:ERROR:wmf-style: class 'toolserver_legacy' includes apache from another module modules/toolserver_legacy/manifests/init.pp:10:wmf_styleguide:ERROR:wmf-style: class 'toolserver_legacy' includes apache::mod::rewrite from another module modules/toolserver_legacy/manifests/init.pp:27:wmf_styleguide:ERROR:wmf-style: class 'toolserver_legacy' declares class exim4 from another module modules/toolserver_legacy/manifests/init.pp:14:wmf_styleguide:ERROR:wmf-style: class 'toolserver_legacy' declares system::role, which should only be used in roles modules/torrus/manifests/init.pp:2:wmf_styleguide:ERROR:wmf-style: class 'torrus' declares system::role, which should only be used in roles modules/torrus/manifests/web.pp:7:wmf_styleguide:ERROR:wmf-style: class 'torrus::web' includes apache::mod::rewrite from another module modules/torrus/manifests/web.pp:8:wmf_styleguide:ERROR:wmf-style: class 'torrus::web' includes apache::mod::headers from another module modules/torrus/manifests/web.pp:9:wmf_styleguide:ERROR:wmf-style: class 'torrus::web' includes apache::mod::perl from another module modules/torrus/manifests/xmlconfig.pp:3:wmf_styleguide:ERROR:wmf-style: class 'torrus::xmlconfig' includes passwords::network from another module modules/torrus/tests/cdn.pp:1:wmf_styleguide:ERROR:wmf-style: role 'role::cache::configuration' should declare system::role once modules/udp2log/manifests/init.pp:16:wmf_styleguide:ERROR:wmf-style: class 'udp2log' includes contacts::udp2log from another module modules/udp2log/manifests/init.pp:33:wmf_styleguide:ERROR:wmf-style: class 'udp2log' declares system::role, which should only be used in roles modules/udp2log/manifests/rsyncd.pp:16:wmf_styleguide:ERROR:wmf-style: class 'udp2log::rsyncd' declares class rsync::server from another module modules/vagrant/manifests/lxc.pp:10:wmf_styleguide:ERROR:wmf-style: class 'vagrant::lxc' includes lxc from another module modules/vagrant/manifests/mediawiki.pp:14:wmf_styleguide:ERROR:wmf-style: class 'vagrant::mediawiki' includes deployment::umask_wikidev from another module modules/varnish/manifests/common/directors.pp:21:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'varnish::common::directors' for 'cluster' modules/varnish/manifests/setup_filesystem.pp:18:wmf_styleguide:ERROR:wmf-style: defined type 'varnish::setup_filesystem' includes labs_lvm from another module modules/varnish/manifests/wikimedia_vcl.pp:18:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'varnish::wikimedia_vcl' for 'varnish::dynamic_backend_caches' modules/varnish/manifests/wikimedia_vcl.pp:23:wmf_styleguide:ERROR:wmf-style: Found hiera call in defined type 'varnish::wikimedia_vcl' for 'cache::traffic_shutdown' modules/visualdiff/manifests/init.pp:8:wmf_styleguide:ERROR:wmf-style: class 'visualdiff' includes mediawiki::packages::fonts from another module modules/wdqs/manifests/monitor/services.pp:47:wmf_styleguide:ERROR:wmf-style: Found hiera call in class 'wdqs::monitor::services' for 'contactgroups' modules/wdqs/manifests/packages.pp:6:wmf_styleguide:ERROR:wmf-style: class 'wdqs::packages' includes java::tools from another module modules/wikilabels/manifests/session.pp:8:wmf_styleguide:ERROR:wmf-style: class 'wikilabels::session' declares class memcached from another module modules/wikimania_scholarships/manifests/init.pp:32:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes passwords::mysql::wikimania_scholarships from another module modules/wikimania_scholarships/manifests/init.pp:33:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes apache from another module modules/wikimania_scholarships/manifests/init.pp:36:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes apache::mod::php7 from another module modules/wikimania_scholarships/manifests/init.pp:39:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes apache::mod::php5 from another module modules/wikimania_scholarships/manifests/init.pp:76:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes apache::mod::rewrite from another module modules/wikimania_scholarships/manifests/init.pp:77:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' includes apache::mod::headers from another module modules/wikimania_scholarships/manifests/init.pp:47:wmf_styleguide:ERROR:wmf-style: class 'wikimania_scholarships' declares system::role, which should only be used in roles modules/yubiauth/manifests/yhsm_aead_sync.pp:5:wmf_styleguide:ERROR:wmf-style: class 'yubiauth::yhsm_aead_sync' includes rsync::server from another module modules/zotero/manifests/init.pp:14:wmf_styleguide:ERROR:wmf-style: class 'zotero' includes service::configuration from another module modules/zuul/manifests/init.pp:20:wmf_styleguide:ERROR:wmf-style: class 'zuul' includes apt from another module Archiving artifacts [WARNINGS]Parsing warnings in files 'log/rake.log' with parser Puppet-Lint [WARNINGS] Searching for all files in /srv/jenkins-workspace/workspace/operations-puppet-wmf-style-guide that match the pattern log/rake.log [WARNINGS] Parsing 1 file in /srv/jenkins-workspace/workspace/operations-puppet-wmf-style-guide [WARNINGS] Successfully parsed file /srv/jenkins-workspace/workspace/operations-puppet-wmf-style-guide/log/rake.log with 2043 unique warnings and 0 duplicates. [WARNINGS]Computing warning deltas based on reference build #466 [WARNINGS]Plug-in Result: Unstable - 2,043 warnings exceed the threshold of 1 by 2,042 Build step 'Scan for compiler warnings' changed build result to UNSTABLE Email was triggered for: Unstable (Test Failures) Sending email for trigger: Unstable (Test Failures)