Some feedback on the rewrite branch - Pywikipedia-l

5 May 2010


      I finally had some time available to start moving my code over to the
rewrite branch, and made some notes along the way.
1: generate_user_files.py fails if the families directory is missing
from PYWIKIBOT2_DIR. Which of course is the case by default if the
environment variable points to an empty directory created somewhere.
It's the call in line 130-131 that fails.  As I prefer to have my
configuration files somewhere outside of my SVN copy of pywikibot, I
solved the problem by creating a symlink.  Could I suggest that
something about this is documented in the INSTALL file or somewhere
else that's easily accessible?
2: As I was instantiating the LoginManager directly, I noticed that
they keyword argument had changed from username to user. Not mentioned
in the conversion docs, although it's an easy fix.
3: Login completely failed (but I figured out why), but also noticed
that it failed with a NameError, there's a reference to _logger in
login.py. I think it's line 153.
4: Once I figured out that the api is the right LoginManager now
(because login.py no longer has a getCookie() method), things were
working again.  Or maybe I'm not supposed to login that way anyway? ;)
5: I still get a couple of warnings when threadedhttp.py is importing
pkg_resources.  I find those annoying and would really like them to go
away.
Cheers,
Morten