Hi! First I am not an expert here, second my thoughts: - sounds good! :) - the two cases (new, append) are not really needed if you just use append, and delete the list by yourself in the file browser (but this is a philosophical issue) - for your save/append code, have a look at [1] and maybe [2] also. In [1] is code quite similar to your proposal and this code is already in use and works. As visible from [2] also a '.decode('latin-1')' is needed for me, this may differ for you, since unicode is quite mysterious... ;)) Hope this helps a bit! Greetings [1] https://fisheye.toolserver.org/browse/drtrigon/pywikipedia/dtbext/dtbext_ba… [2] https://fisheye.toolserver.org/browse/drtrigon/pywikipedia/sum_disc.py?r=HE… Am 22.10.2010 11:16, schrieb Bináris:

Am 23.10.2010 12:13, schrieb Bináris: you could try dooing so by using threading.Event or similar (e.g. signal) Greetings

Thank you, I have read this, but here I reach the current limits of my knowledge. Once I will know how. I would appreciate every help. My version is at https://sourceforge.net/tracker/?func=detail&aid=3093682&group_id=9… 2010/10/23 Merlijn van Deen <valhallasw(a)arctus.nl> -- Bináris

Is there any reason or advantage for putting the page in asyncron mode while I am using replace.py manually? I guess this should be changed to normal put and put operation in -always mode maybe done asyncroneously to save time for searching and processing the next pages like interwiki.py does it with -async option. Greetings xqt ----- Original Nachricht ---- Von: Merlijn van Deen <valhallasw(a)arctus.nl> An: Pywikipedia discussion list <pywikipedia-l(a)lists.wikimedia.org> Datum: 23.10.2010 15:08 Betreff: Re: [Pywikipedia-l] Replace.py should save -- please comment

2010/10/23 Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; I tried to learn and read this threading stuff in order to have a correct editcounter. (If was quite a time ago, so someone might forget the topic: I created an editcounter in class ReplaceRobot of replace.py and was disappointed with my counter not listening to the failure of put_async. Now I created a callback function: def lacika(self, page, err): if err is None: print u'%s saved successfully' % page.title() #for debug else: print 9999999 self.editcounter -= 1 print self.editcounter Now I ran four tests: 1. Successful save, it's OK. 2. After loading the page, while replace.py waits for my choice, I protected the page. Result: 1 page was changed. <-- message from main process Updating page [[Szerkesztő:BinBot/semmi]] via API 9999999 <-- just a test message from callback 0 <-- New self.editcounter, correct, but too late Here comes my first problem. As far as I understood, I should use *join* to make the main process wait for put_async. But put_asyn is taken from wikipedia.py. How can I use *join* here, where should I write it? Could someone write a simple example to make the bot wait for put_async? 3rd test: I created an edit conflict with the same result. (I made the bot to write err instead of 9999999, it's OK.) 4th test: After loading the page, while the bot is waiting for my choice, I delete the page. This seems to be a bug: 1 page was changed. Updating page [[Szerkesztő:BinBot/semmi]] via API Unknown Error. API Error code:missingtitle Information:The article you tried to edit doesn't exist Szerkeszt<:BinBot/semmi saved successfully First, the error is not handled, second, callback got None for error and reported a false success. -- Bináris

Hi Binaris I did not write the any of the threaded stuff in wikipedia.py but I have used it a couple of times. I think what you should do is provide a callable _object_ and not a callback function. You can then iterate through the list of callback objects and look at the errors if there are any. Here is a sample program I wrote to illustrate the concept: import wikipedia as pywikibot from time import sleep pages = [ 'User:HRoestBot/CallbackTest1', 'User:HRoestBot/CallbackTest2', ] class CallbackObject(object): def __init__(self): self.done = False def __call__(self, page, error): self.page = page self.error = error self.done = True Callbacks = [] for mypage in pages: print(mypage); callb = CallbackObject() page = pywikibot.Page(pywikibot.getSite(), mypage) Callbacks.append(callb) page.put_async('some text', callback=callb) # Waiting until all pages are saved on Wikipedia while True: if all( [c.done for c in Callbacks] ): break print "Still Waiting" sleep(5) # Now we can look at the errors for obj in Callbacks: print obj.page, obj.error if not obj.error is None: # do something to handle errors The output of such a program may then be $ python test.py unicode test: triggers problem #3081100 HRoestBot/CallbackTest1 HRoestBot/CallbackTest2 Sleeping for 4.0 seconds, 2012-02-24 09:32:57 Still Waiting Still Waiting Updating page [[HRoestBot/CallbackTest1]] via API Still Waiting Sleeping for 19.3 seconds, 2012-02-24 09:33:18 Still Waiting Updating page [[HRoestBot/CallbackTest2]] via API Still Waiting [[de:HRoestBot/CallbackTest1]] An edit conflict has occured. [[de:HRoestBot/CallbackTest2]] An edit conflict has occured. hr@hr:~/projects/private/pywikipedia_gitsvn$ At least that is how I do it. I hope that helps to understand. You can also use pywikibot.page_put_queue.qsize() and pywikibot.page_put_queue.empty() to check whether the queue is empty or not but this might still lead to problems because the page is fetched from the queue and *then* page.put is called on it. So until page.put() finishes, the queue will be empty even though the bot is still putting the page. See the function def async_put(), it seems to me much safer to rely on the Callback objects to be sure that all the put-calls are done. You can also look at _flush() method in wikipedia.py to see how it determines whether all pages are put and its save to exit or not. Hannes On 23 February 2012 21:30, Bináris &lt;wikiposta(a)gmail.com&gt; wrote: