On 15 January 2015 at 13:02, Fabian Neundorf <CommodoreFabianus@gmx.de> wrote:

> And just for clarification, when someone uploads a patch, not the
> e-mail in the git commit are important but the account which you used
> to push it to the repository?

Yes, the account used to submit the Gerrit changeset.

> Couldn't you automatically generate a
> list automatically from the admins (or +2able contributors?) of the
> project?

And why is it okay to run the test on a CR+1 vote (which is
afaik everyone with an account) but not on push?

The test are triggered on a +1 from /whitelisted accounts/.

The list of whitelisted accounts is here: https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L108

As a workaround, posting 'recheck' should also trigger the tests. Antoine, maybe it's an idea to also trigger on comments that start with 'check' (instead of 'only contain recheck')? That might be easier to implement than your +1 solution.

Merlijn