On Sat, Sep 21, 2013 at 12:00 AM, Maarten Dammers <maarten@mdammers.nl> wrote:
Hi Jeroen,

Op 20-9-2013 16:25, Jeroen De Dauw schreef:


> I wonder if Jeroen looked at the code in compat or in core. Core is much cleaner than compat. Jeroen?

agreed with Maarten, Core branch is handling Wikibase by the data model but the compat has just a subclass of page named "DataPage" and it has some methods handling items (doesn't have anything for properties at all) Actually I wrote the DataPage class and I did that because I think we don't need to implement the whole Data model for running but in a Wikibase-repo wiki

 
Can you link to the specific code?
* https://git.wikimedia.org/tree/pywikibot%2Fcore.git
* https://git.wikimedia.org/blob/pywikibot%2Fcore.git/58800272e1b55323bd1989f1a1457cb5299ed626/pywikibot%2Fpage.py#L2304
* https://git.wikimedia.org/blob/pywikibot%2Fcore.git/58800272e1b55323bd1989f1a1457cb5299ed626/pywikibot%2Fsite.py#L3406

Maarten


_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l


Best
--
Amir