Ladsgroup added a subscriber: Ladsgroup. Ladsgroup added a comment. I think the isbn.py should be moved to the pywikibot as a whole and then we make a wrapper to in scripts folder so people would be able to run it as a script. TASK DETAIL https://phabricator.wikimedia.org/T89993 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

jayvdb added a comment. We do not need all of the deprecated stuff from isbn.py . We need to pick one of the isbn libraries added in https://phabricator.wikimedia.org/T85240, which will become a formal dependency in setup.py and requirements.txt , and possible copy the wrapper around it from isbn.py into the pywikibot library. Are any of the ISBN libraries already available / in use on https://phabricator.wikimedia.org/tag/tool-labs/ ? TASK DETAIL https://phabricator.wikimedia.org/T89993 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

jayvdb added a comment. In https://phabricator.wikimedia.org/T89993#1051089, @Ladsgroup wrote: Well, it isnt even @deprecated yet. It is easy to leave it where it is, deprecate it, and remove it after pywikibot is released onto pypi and we can start work on a new version of pywikibot. I am not seeing anything in isbn.py that would be desirable in the pywikibot library. When we pick an isbn library and make it a dependency, cosmetic changes can use that library directly, or if we want to support multiple isbn libraries we can create a much neater wrapper in pywikibot.tools.isbn . TASK DETAIL https://phabricator.wikimedia.org/T89993 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 205837 had a related patch set uploaded (by John Vandenberg): Remove cosmetic changes dependency on isbn script https://gerrit.wikimedia.org/r/205837 TASK DETAIL https://phabricator.wikimedia.org/T89993 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

gerritbot added a comment. Change 205837 merged by jenkins-bot: Remove cosmetic changes dependency on isbn script https://gerrit.wikimedia.org/r/205837 TASK DETAIL https://phabricator.wikimedia.org/T89993 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

jayvdb closed blocking task T89996: Add isbn package dependency as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T89993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Liuxinyu970226, gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs

Liuxinyu970226 removed a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T89993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, Liuxinyu970226 Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs