On Sun, Feb 22, 2015 at 10:16 PM, John Mark Vandenberg <jayvdb(a)gmail.com> wrote: wrote: them Careful what I ask for I guess. Amir, please do not spam people unnecessarily. you say 'needs rebase' to this patch, which has two -1's on it. https://gerrit.wikimedia.org/r/#/c/141392/ It needs more than a rebase, so please dont do that. Many of the other comments you are adding are equally useless. -- John Vandenberg _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

On Sun, Feb 22, 2015 at 10:33 PM, Amir Ladsgroup <ladsgroup(a)gmail.com> wrote: What is the problem that you are trying to solve? Gerrit allows filtering by review status using url parameters, etc, so 'too many patches' is hardly a problem. You can bookmark patches which are not -1'd. If there are patches which are fundamentally wrong, adding -2 and abandoning them is helpful. Reviewing possibly problematic patches is helpful. Rebasing other peoples patches is helpful, especially if you also address the minor review issues. Many of the patches have put on hold due to other larger problems; the dependencies are sometimes explained in the comments; if not, asking why a good patch is on hold is useful. But pushing old patches onto the top of the queue for no reason and without a review comment, that is not helpful. -- John Vandenberg _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l