There are two kinds of NotImplementedError,
Some of them are not implemented because we don't want to (e.g. non-API
requests)
Some of them are not implemented yet but I'll be good if we implement them
(e.g. page.interwiki() )
if you can find the latter errors and log them it would be great, I promise
I'll help on review
Best
On Tue, Dec 10, 2013 at 4:44 PM, Strainu <strainu10(a)gmail.com> wrote:
2013/12/9 Merlijn van Deen
<valhallasw(a)arctus.nl>nl>:
Hi Strainu,
Thanks for the suggestions!
The _address functions are not used in core -- those were the 'pages to
be
screen scraped' in compat.
However, adding missing (useful) functionality would be great. I'm not
sure
if a list exists, though. One example is the work
by Allen in
https://gerrit.wikimedia.org/r/#/c/100363/, but there might be others.
At Amir's suggestion, I grep'ed for NotImplemented and found this huge
list, plus one in Page.delete, which I've logged as a task. Bug 55037
is another open task.
Otherwise, these are some scripts that might be nice to have ported, and
that do not seem unreasonably hard:
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/revertbot.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/disambredir.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/pagefromfile.py
>
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/makecat.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/commons_link.py
>
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/catall.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/lonelypages.py
> (not sure if this is still useful - there might be a toolserver tool for
> this?)
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/imagetransfer.py
> These are harder, but also more
useful:
>
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/archivebot.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/weblinkchecker.py
https://git.wikimedia.org/blob/pywikibot%2Fcompat.git/HEAD/casechecker.py
> Could we make tasks for those?
I went on a streak and created tasks for all of these. I've allocated
3 days for the easy ones and 5 days for the others - this is more of a
guideline, we've always extended deadlines if the students were making
progress towards resolving the tasks.. (Un)fortunately I'll only be
around for a week to nag you with reviews or questions before the
winter beak, but I'm hoping there will be someone available to review
the submissions at least until 12/22.
Thanks,
Strainu
> Merlijn
> On 9 December 2013 21:02,
Strainu <strainu10(a)gmail.com> wrote:
>>
>> Hi,
>>
>> Should I log a task for porting from compat to core all functions not
>> implemented in site.py (like ancientpages_address)?
>>
>> I see a comment saying "unsupported methods from version 1" and
it's
>> unclear to me if these are useless or just not implemented.
>>
>> Thanks,
>> Strainu
>>
>> _______________________________________________
>> Pywikipedia-l mailing list
>> Pywikipedia-l(a)lists.wikimedia.org
>>
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
>
_______________________________________________
> Pywikipedia-l mailing list
> Pywikipedia-l(a)lists.wikimedia.org
>
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l