! In T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is pointless since the point of code
review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540g...
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFab...
What was the reason for this fork and was is intended for the future of it? How is it usable with the current framework? Are the given scripts to be removed from it? And why the separation between framework and user script was abandoned there.
Greetings xqt
Hey Xqt, I'm happy you brought this issue but currently I'm working on it and it's not finished. I must note that some parts are forked not all parts. It won't be an alternative of pywikibot for wikibase.
On Mon, Aug 10, 2015 at 6:04 PM info@gno.de wrote:
What was the reason for this fork and was is intended for the future of it?
It will be a mandatory submodule of pywikibot and it will be used (at least) by pywikibot and some other projects. We did this because developers of pywikibot agreed on splitting the library on several layers and I heard from some people that handling data model of wikibase is hard but for tasks like that they can't install pywikibot. Using it is hard and requires redundant variables and attributes for wide broad potentially use cases. e.g. someone wants to read json dumps of wikidata and to get how many statements are in items. In ideal world (s)he doesn't need to connect to internet or define pywikibot.Site, etc. but we require them to do. So I thought it's a good idea and after some talks in Wikimania and approvals from pywikibot devs and wikidata devs I started doing this.
How is it usable with the current framework?
It will be used by multiple inheritance inside the library and parts related to the classes of WikibasePage, ItemPage, PropertyPage, Claim, Property, etc. e.g. class WikibasePage(Page, pywikibase.WikibasePage):
And then we use attributes and methods of pywikibase.WikibasePage
Are the given scripts to be removed from it?
Yes
And why the separation between framework and user script was abandoned
there.
Because it will be used by library of pywikibot not scripts. Scripts will use it indirectly.
Greetings xqt
pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
Hi Ricordisamoa,
On 10 August 2015 at 15:19, Ricordisamoa ricordisamoa@openmailbox.org wrote:
! In T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is pointless since the point of code
review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540g...
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFab...
As far as I'm concerned, +1, -1 and -2 are all part of communication between reviewers and author. Do you feel the use of +1 as linked hampers your work as author or reviewer? This is not clear to me from your e-mail.
Merlijn
For me these +1s from John or Fabian mean, "review these ones sooner" not "I approve these but not other patches of mine" or "I didn't wrote other patches"
Best
On Mon, Aug 10, 2015 at 8:28 PM Merlijn van Deen valhallasw@arctus.nl wrote:
Hi Ricordisamoa,
On 10 August 2015 at 15:19, Ricordisamoa ricordisamoa@openmailbox.org wrote:
! In T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is pointless since the point of code
review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540g...
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFab...
As far as I'm concerned, +1, -1 and -2 are all part of communication between reviewers and author. Do you feel the use of +1 as linked hampers your work as author or reviewer? This is not clear to me from your e-mail.
Merlijn _______________________________________________ pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot
Il 10/08/2015 17:58, Merlijn van Deen ha scritto:
Hi Ricordisamoa,
On 10 August 2015 at 15:19, Ricordisamoa <ricordisamoa@openmailbox.org mailto:ricordisamoa@openmailbox.org> wrote:
>>! In T106359#1506339, @Ciencia_Al_Poder wrote: > Scoring your own patches with +1 is pointless since the point of code review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress". https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540gmail.com+label:Code-Review%252B1%252Cuser%253Djayvdb%2540gmail.com,n,z https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFabianus%2540gmx.de+label:Code-Review%252B1%252Cuser%253DCommodoreFabianus%2540gmx.de,n,zAs far as I'm concerned, +1, -1 and -2 are all part of communication between reviewers and author. Do you feel the use of +1 as linked hampers your work as author or reviewer? This is not clear to me from your e-mail.
Merlijn
Hi, I'm not totally against +1 on own patches, but I've seen it used a bit lightly.
This discussion reminded me of a funny quip[1]:
<TimStarling> what does +1 mean anyway? <Brooke> Reviewer has a working mouse.
But if other people find them useful (like Amir explained) I don't see any problem with using +1 liberally :)
[1] https://tools.wmflabs.org/bash/quip/AU7VVae36snAnmqnK_xL
-- Legoktm
On Mon, 10 Aug 2015 23:20 Ricordisamoa ricordisamoa@openmailbox.org wrote:
! In T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is pointless since the point of code
review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".
While Ciencia_Al_Poder may believe that Paladox approves all of their own patches, especially after many pointless rebases as documented in T106359, it is funny if you think that Fabian or I automatically approve of all our own patches. Often they are only demonstrating a problem, a possible solution, and definitely need some fine tuning. And often several solutions exist in Gerrit, even by the same person.
For my own patches, especially if they have slipped past reviewers or it is urgent, I try to review the path with very critical eyes as if it wasnt my own patch.
On Wed, Aug 12, 2015 at 4:55 AM, Ricordisamoa ricordisamoa@openmailbox.org wrote:
Hi, I'm not totally against +1 on own patches, but I've seen it used a bit lightly.
Could you provide some examples of where you believe self +1's are being overused? I have a fairly constant stream of patches that I shouldn't have +1'd as it had a problem that I hadnt noticed. And some of those are my own patches. e.g. https://gerrit.wikimedia.org/r/#/c/229731/ was a particularly careless self +1.
-- John Vandenberg