Ah, maybe. I just saw your "fixes" at my Talk page(s). xqt ----- Ursprüngliche Nachricht ----- Von: Amir Ladsgroup Gesendet: 26.07.2014 23:22 An: Pywikibot discussion list Betreff: Re: [Pywikipedia-l] The build is broken it was another bug that John and Ricordisamoa are talking about. On 7/27/14, info(a)gno.de <info(a)gno.de> wrote: -- Amir _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

From my understanding (I have not tried, just looked at the code), archivebot.py allows a timestamp to be None. See def should_be_archived(). In that case the thread is not added to the list of threads to be archived but it is left on the talk page. So technically it is not 100% correct to test for a timestamp to be mandatory on the talkpage itself, but only on the threads to be archived. After all, handling the unsigned case is still TODO in the script. I think this proposal above by JVB sounds reasonable: i.e. to allow also None as test result in line 63 of archivebot_test.py Mpaa On Sun, Jul 27, 2014 at 1:44 AM, Amir Ladsgroup <ladsgroup(a)gmail.com> wrote:

Recently we had a few cases of code that didnt compile getting merged (I have +2 some of them.. :/), so I have fast tracked the addition of a set of tests which run every script with -help , and with -simulate. These new tests add about 3 minutes to the test suite execution, and add basic validation that the scripts compile and at least main() can be executed. There are a few scripts which do not emit help on -help, Not too many. The -simulate argument prevents the scripts from writing to any wiki. Without any other argument, the script should do argument parsing, and usually quit as if called with -help, or provide some informative error message. Many scripts do not do proper argument parsing and environment sanity checking, resulting in exceptions. The new tests, annotated with bug numbers, is here: http://git.wikimedia.org/blob/pywikibot%2Fcore.git/master/tests%2Fscript_te… The "auto_run_script_list" is the list of scripts which start work without any additional arguments. For those scripts, the tester may wait up to 5 seconds before it kills the process - we may be able to reduce that delay per script by fixing some of the bugs. Due to some fancy legwork by Legoktm, we now have six Travis builds occurring after each checkin, including running these tests against 1. English Wikipedia, 2. Arabic Wikipedia, and 3. Wikidata. https://travis-ci.org/wikimedia/pywikibot-core This means that a month old critical bug is now visible in the two Arabic Wikipedia builds which are failing. There is a patch to be reviewed: https://gerrit.wikimedia.org/r/#/c/149898/ The 'basic' script failing on the py2.6 wikidata build seems to be because py2.6 unit tests are executed in alpha order of the test script name, and the wikidata login doesnt happen earlier for wikidata, but does occur earlier for test scripts against English and Arabic Wikipedia. I am currently working on a fix for this build problem. -- John Vandenberg _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

Mpaa: I meant getting section date by getting history and analyzing revisions instead of checking signature on them. Best On 8/2/14, Mpaa <mpaa.wiki(a)gmail.com> wrote: http://git.wikimedia.org/blob/pywikibot%2Fcore.git/master/tests%2Fscript_te… -- Amir _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l