Is there a styleguide or was there a discussion already, because I think it would be good to have at least some set of rules. Some are already handled by flake8 so jenkins will prevent that some style guides are broken but there is for example: * PEP-8 compatible names. Should all new attributes/method/variables be PEP-8 compatible? There is a task on phabricator to be compliant with the 2.0 release (so with 3.0 the other code can be removed) https://phabricator.wikimedia.org/T85328 * Another is whether we want to use %-notation or str.format. I personally prefer the str.format because it doesn't require any magic but many submissions use %-notation and I previously didn't care about that. But should we only use one mode and which of those then? And when we allow both and others ask what they should use, should I recommend what we like or do we want to have one recommendation? * Last week (afaik) I noted on this list the line lengths (I probably should update them now where Amir's patch was merged). Should we enforce a specific limit (like 100 chars?). I also saw that gerrit supported to show a line to indicate the 80 character width. Is it possible to enable that on our gerrit (to make it easier for us to see)? If you have additional points which could be defined in a style guide please let me know. Fabian _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l