For me these +1s from John or Fabian mean, "review these ones sooner" not "I approve these but not other patches of mine" or "I didn't wrote other patches"
Best
On Mon, Aug 10, 2015 at 8:28 PM Merlijn van Deen valhallasw@arctus.nl wrote:
Hi Ricordisamoa,
On 10 August 2015 at 15:19, Ricordisamoa ricordisamoa@openmailbox.org wrote:
! In T106359#1506339, @Ciencia_Al_Poder wrote:
Scoring your own patches with +1 is pointless since the point of code
review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540g...
https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFab...
As far as I'm concerned, +1, -1 and -2 are all part of communication between reviewers and author. Do you feel the use of +1 as linked hampers your work as author or reviewer? This is not clear to me from your e-mail.
Merlijn _______________________________________________ pywikibot mailing list pywikibot@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot