I disagree because maybe someone breaks the regex of detecting
signature date and the test should be able to detect that. The best
solution IMHO is to find sections via their revision timestamp but
Flow will come and everything will be solved YAYYYY
Best
On 8/2/14, Mpaa <mpaa.wiki(a)gmail.com> wrote:
From my understanding (I have not tried, just looked
at the code),
archivebot.py allows a timestamp to be None.
See def should_be_archived().
In that case the thread is not added to the list of threads to be archived
but it is left on the talk page.
So technically it is not 100% correct to test for a timestamp to be
mandatory on the talkpage itself, but only on the threads to be archived.
After all, handling the unsigned case is still TODO in the script.
I think this proposal above by JVB sounds reasonable:
Or maybe the unit test could allow unsigned
sections to be added to
the talk page.
i.e. to allow also None as test result in line 63 of archivebot_test.py
Mpaa
On Sun, Jul 27, 2014 at 1:44 AM, Amir Ladsgroup <ladsgroup(a)gmail.com>
wrote:
Sorry for doing that. I had to do it but I
didn't have time to check
archivebot.py (which is a huge code) and find best fix for it but
builds were failing and we were fixing them one by one.
Anyone interested in fixing archivebot.py bug?
Best
On 7/27/14, info(a)gno.de <info(a)gno.de> wrote:
Ah, maybe. I just saw your "fixes" at
my Talk page(s).
xqt
----- Ursprüngliche Nachricht -----
Von: Amir Ladsgroup
Gesendet: 26.07.2014 23:22
An: Pywikibot discussion list
Betreff: Re: [Pywikipedia-l] The build is broken
it was another bug that John and Ricordisamoa are talking about.
On 7/27/14, info(a)gno.de <info(a)gno.de> wrote:
This is not a bug in testing. The test detects a
bug for archivebot.py
which
fails for unsigned threads.
xqt
----- Ursprüngliche Nachricht -----
Von: John Mark Vandenberg
Gesendet: 26.07.2014 18:21
An: Pywikibot discussion list
Betreff: Re: [Pywikipedia-l] The build is broken
On Sat, Jul 26, 2014 at 10:39 PM, Ricordisamoa
<ricordisamoa(a)openmailbox.org> wrote:
>
> The build is still broken, but because of this edit, that breaks the
> timestamp detection of the ArchiveBot.
> Maybe a fictitious, write-protected talk page should be used?
That is being tracked on
https://bugzilla.wikimedia.org/show_bug.cgi?id=67663
An alternative test page would be a good solution.
Or maybe the unit test could allow unsigned sections to be added to
the talk page.
--
John Vandenberg
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
--
Amir
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
--
Amir
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l