Hi,
Could you provide an example of a page that currently doesn't work? I just
ran our test suite on the latest revision and the fromPage-related tests
all passed.
Your current patch technically works, however I'd be wary of accepting it
since it makes the API request while the item is being constructed, rather
than passing on the site & title parameters to the write function that
needs it (lazy).
-- Legoktm
On Sat, Jul 20, 2013 at 5:58 PM, Tomasz Magulski
<tomasz.magulski(a)gmail.com>wrote;wrote:
Hi,
I've started to work with wikidata few days ago and have found out, that
in rewrite branch ItemPage.fromPage haven't worked properly, so I had
started digging in code and made small patch, which should resolve this
issue.
The code is available here:
https://github.com/magul/pywikibot-core/tree/ItemPageFromPage
Could be it merged to rewrite branch? What should I do to make it happen?
Thanks for answer in advance
--
Tomasz Magulski
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l