On 17 February 2012 10:03, Hannes Röst <hroest_nospam2333@quantentunnel.de> wrote:
What are the criteria to get SVN commit access -- I was just wondering
what the general rules are.
The general rule is that there should be someone who already has access supports your request. In general, this is a basic check on code quality (which look OK to me), and on communication (we've had someone with svn access who did do commits, but didn't reply to comments...) - which is also OK as far as I can see.
If you feel you can integrate it with the framework in a sensible way (e.g. get_all_templates should use the one in the framework), I think you should just get SVN access (we can always revoke it if you're horrible after all ;-)).
If no-one disagrees with me on this (within, say, a week or so), feel free to send an e-mail to Sumana Harihareswara (who coordinates SVN access) at
sumanah@wikimedia.org, linking to this thread (e.g. a link to the mail at [1]).
Best,
Merlijn