jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/501874 )
Change subject: [tests] Simplify site_tests.testDataSiteSearchEntities.test_general code
......................................................................
[tests] Simplify site_tests.testDataSiteSearchEntities.test_general code
- use list for tests instead of creating it twice
- use assertIsNotEmpty method
Change-Id: I9b1d5118de29f55c50e298ff019a75a1052d5bb2
---
M tests/site_tests.py
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
D3r1ck01: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index b090ccf..f9ef079 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -3290,13 +3290,13 @@
def test_general(self):
"""Test basic search_entities functionality."""
datasite = self.get_repo()
- pages = datasite.search_entities('abc', 'en', total=50)
- self.assertGreater(len(list(pages)), 0)
- self.assertLessEqual(len(list(pages)), 50)
- pages = datasite.search_entities('alphabet', 'en',
type='property',
- total=50)
- self.assertGreater(len(list(pages)), 0)
- self.assertLessEqual(len(list(pages)), 50)
+ pages = list(datasite.search_entities('abc', 'en', total=50))
+ self.assertIsNotEmpty(pages)
+ self.assertLessEqual(len(pages), 50)
+ pages = list(datasite.search_entities('alphabet', 'en',
+ type='property', total=50))
+ self.assertIsNotEmpty(pages)
+ self.assertLessEqual(len(pages), 50)
def test_continue(self):
"""Test that continue parameter in search_entities
works."""
--
To view, visit
https://gerrit.wikimedia.org/r/501874
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b1d5118de29f55c50e298ff019a75a1052d5bb2
Gerrit-Change-Number: 501874
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)