jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/348968 ) Change subject: Fix invalid escape sequences ...................................................................... Fix invalid escape sequences These sequences raise DeprecationWarning under Python 3.6. Change-Id: I07bc60af045deafd1371cec9e98656810846c555 --- M tests/i18n_tests.py M tests/pagegenerators_tests.py 2 files changed, 10 insertions(+), 6 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/i18n_tests.py b/tests/i18n_tests.py index 355f5fd..72e69a5 100644 --- a/tests/i18n_tests.py +++ b/tests/i18n_tests.py @@ -300,9 +300,13 @@ def testMultipleNonNumbers(self): """Test error handling for multiple non-numbers.""" - with self.assertRaisesRegex(ValueError, "invalid literal for int\(\) with base 10: 'drei'"): + with self.assertRaisesRegex( + ValueError, r"invalid literal for int\(\) with base 10: 'drei'" + ): i18n.twntranslate('de', 'test-multiple-plurals', ["drei", "1", 1]) - with self.assertRaisesRegex(ValueError, "invalid literal for int\(\) with base 10: 'elf'"): + with self.assertRaisesRegex( + ValueError, r"invalid literal for int\(\) with base 10: 'elf'" + ): i18n.twntranslate('de', 'test-multiple-plurals', {'action': u'Ändere', 'line': "elf", 'page': 2}) diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 50628bd..3ecc433 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -1085,8 +1085,8 @@ """Test -onlyif without qualifiers.""" gf = pagegenerators.GeneratorFactory(site=self.site) gf.handleArg('-page:Q15745378') - gf.handleArg('-onlyif:P1476=International Journal of Minerals\, ' - 'Metallurgy\, and Materials') + gf.handleArg('-onlyif:P1476=International Journal of Minerals\\, ' + 'Metallurgy\\, and Materials') gen = gf.getCombinedGenerator() self.assertIsNotNone(gen) self.assertEqual(len(set(gen)), 1) @@ -1095,8 +1095,8 @@ """Test -onlyifnot without qualifiers.""" gf = pagegenerators.GeneratorFactory(site=self.site) gf.handleArg('-page:Q15745378') - gf.handleArg('-onlyifnot:P1476=International Journal of Minerals\, ' - 'Metallurgy\, and Materials') + gf.handleArg('-onlyifnot:P1476=International Journal of Minerals\\, ' + 'Metallurgy\\, and Materials') gen = gf.getCombinedGenerator() self.assertIsNotNone(gen) self.assertEqual(len(set(gen)), 0) -- To view, visit https://gerrit.wikimedia.org/r/348968 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07bc60af045deafd1371cec9e98656810846c555 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>