jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/736187 ) Change subject: [cleanup] remove deprecated version.get_module_version() function ...................................................................... [cleanup] remove deprecated version.get_module_version() function This function gives no meaningfull result because our modules does no have any __version__ information. Change-Id: I2d96fbab07334430d7617cc38cf902bbacbb53d7 --- M pywikibot/version.py 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/version.py b/pywikibot/version.py index 0e831e9..d759c18 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -25,7 +25,6 @@ from pywikibot.backports import cache from pywikibot.comms.http import fetch from pywikibot.exceptions import VersionParseError -from pywikibot.tools import deprecated _logger = 'version' @@ -342,21 +341,6 @@ raise VersionParseError('{!r} while parsing {!r}'.format(e, buf)) -(a)deprecated('pywikibot.__version__'n__', since='20201003') -def get_module_version(module) -> Optional[str]: # pragma: no cover - """ - Retrieve __version__ variable from an imported module. - - :param module: The module instance. - :type module: module - :return: The version hash without the surrounding text. If not present - return None. - """ - if hasattr(module, '__version__'): - return module.__version__ - return None - - def get_module_filename(module) -> Optional[str]: """ Retrieve filename from an imported pywikibot module. -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/736187 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I2d96fbab07334430d7617cc38cf902bbacbb53d7 Gerrit-Change-Number: 736187 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged