jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/557548 )
Change subject: [IMPR] Skip transferbot script if unknown arguments are given ......................................................................
[IMPR] Skip transferbot script if unknown arguments are given
Change-Id: I0cc53bdf21459a388b27056c969e13add1ccb619 --- M scripts/transferbot.py 1 file changed, 2 insertions(+), 6 deletions(-)
Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/transferbot.py b/scripts/transferbot.py index eff9df1..209717c 100755 --- a/scripts/transferbot.py +++ b/scripts/transferbot.py @@ -47,7 +47,7 @@ """ # # (C) Merlijn van Deen, 2014 -# (C) Pywikibot team, 2014-2019 +# (C) Pywikibot team, 2014-2020 # # Distributed under the terms of the MIT license. # @@ -101,16 +101,12 @@ else fromsite) unknown_args = [arg for arg in gen_args if not gen_factory.handleArg(arg)]
- if unknown_args: - for item in unknown_args: - gen_args.remove(item) - gen = gen_factory.getCombinedGenerator()
suggest_help(missing_generator=not gen, additional_text=additional_text, unknown_parameters=unknown_args) - if additional_text or not gen: + if additional_text or not gen or unknown_args: return
gen_args = ' '.join(gen_args)
pywikibot-commits@lists.wikimedia.org