jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360090 )
Change subject: deprecate site.newfiles() method
......................................................................
deprecate site.newfiles() method
- newfiles() could easily by replaced by logevents(logtype='upload'),
deprecate this method.
- update compat2core.py
Bug: T168339
Change-Id: Idad73898ec0e6772e045e36b7347f4f764ae8cf5
---
M pywikibot/site.py
M scripts/maintenance/compat2core.py
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 48a8877..e2bc6cc 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -6383,19 +6383,20 @@
yield (newpage, pageitem['timestamp'],
pageitem['newlen'],
u'', pageitem['user'],
pageitem['comment'])
+ @deprecated('APISite.logevents(logtype="upload")')
@deprecated_args(lestart='start', leend='end', leuser='user',
letitle=None,
repeat=None, number='total', step=None)
def newfiles(self, user=None, start=None, end=None, reverse=False,
total=None):
"""Yield information about newly uploaded files.
+ DEPRECATED: Use logevents(logtype='upload') instead.
+
Yields a tuple of FilePage, Timestamp, user(unicode), comment(unicode).
N.B. the API does not provide direct access to Special:Newimages, so
this is derived from the "upload" log events instead.
-
"""
- # TODO: update docstring
for event in self.logevents(logtype="upload", user=user,
start=start, end=end, reverse=reverse,
total=total):
@@ -6405,13 +6406,13 @@
comment = event.comment() or u''
yield (filepage, date, user, comment)
- @deprecated("Site().newfiles()")
+ @deprecated('APISite.logevents(logtype="upload")')
@deprecated_args(number='total', repeat=None)
def newimages(self, *args, **kwargs):
"""
Yield information about newly uploaded files.
- DEPRECATED: Use newfiles() instead.
+ DEPRECATED: Use logevents(logtype='upload') instead.
"""
return self.newfiles(*args, **kwargs)
diff --git a/scripts/maintenance/compat2core.py b/scripts/maintenance/compat2core.py
index ec7a3dc..8e3b9d4 100755
--- a/scripts/maintenance/compat2core.py
+++ b/scripts/maintenance/compat2core.py
@@ -79,7 +79,8 @@
(r'\.aslink\s*\(\s*\)', '.title(asLink=True)'),
# other deprecated methods
(r'(?<!site)\.encoding\s*\(\s*\)', '.site.encoding()'),
- (r'\.newimages\s*\(', '.newfiles('),
+ (r'\.newimages\s*\(\)', ".logevents(logtype='upload')"),
+ (r'\.newimages\s*\(([^)])', r".logevents(logtype='upload',
\1"),
(r'\.getRestrictions\s*\(', '.protection('),
# new core methods and properties
(r'\.get\s*\(\s*get_redirect\s*=\s*True\s*\)', '.text'),
--
To view, visit
https://gerrit.wikimedia.org/r/360090
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idad73898ec0e6772e045e36b7347f4f764ae8cf5
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>