jenkins-bot has submitted this change and it was merged.
Change subject: [IMPR] remove superfluous assignment to a instance variable
......................................................................
[IMPR] remove superfluous assignment to a instance variable
self.hiddentemplates is a instance variable which might be expanded
in loadHiddenTemplates() method. A reassignment is not necessary.
Change-Id: I79bad15e6000c83d3b5f5249d68bc1d3c78edf77
---
M scripts/checkimages.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
XZise: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index ffaf9d0..85cd5a0 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -867,7 +867,6 @@
for element in self.load(pageHiddenText):
self.hiddentemplates.add(pywikibot.Page(self.site, element))
- return self.hiddentemplates
def returnOlderTime(self, listGiven, timeListGiven):
"""Get some time and return the oldest of them."""
@@ -1321,7 +1320,7 @@
regex_are_licenses = re.compile(
r'(?<!\{)\{\{(?:[Tt]emplate:|)([^{]+?)\}\}', re.DOTALL)
while True:
- self.hiddentemplates = self.loadHiddenTemplates()
+ self.loadHiddenTemplates()
self.licenses_found = self.image.templates()
templatesInTheImageRaw = regex_find_licenses.findall(
self.imageCheckText)
--
To view, visit
https://gerrit.wikimedia.org/r/234593
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79bad15e6000c83d3b5f5249d68bc1d3c78edf77
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>