jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357574 )
Change subject: [bugfix] Adjust _treat_counter
......................................................................
[bugfix] Adjust _treat_counter
redirect.py always reads one page on top of the -total number. The reason is
that Bot.run increases the _treat_counter after the treat(page) was done but
RedirectBot uses the old value after action() was done. Fix this behavior.
Bug: T167254
Change-Id: Ia5a0fa722a26a0614508804f2842c38ee4f7a509
---
M scripts/redirect.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/redirect.py b/scripts/redirect.py
index 9bd6e7a..c44ae5f 100755
--- a/scripts/redirect.py
+++ b/scripts/redirect.py
@@ -735,11 +735,11 @@
def treat(self, page):
"""Treat a single page."""
- self.action_treat(page)
if self._treat_counter >= self.getOption('total'):
pywikibot.output('\nNumber of pages reached the total limit. '
'Script terminated.')
self.quit()
+ self.action_treat(page)
def main(*args):
--
To view, visit
https://gerrit.wikimedia.org/r/357574
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5a0fa722a26a0614508804f2842c38ee4f7a509
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>