jenkins-bot has submitted this change and it was merged.
Change subject: Skip siteinfo tests that require v1.16+ values
......................................................................
Skip siteinfo tests that require v1.16+ values
'time' and 'articlepath' are MW v1.16+
Change-Id: I523b923c5fc672327c4a10748373335cb8385aa0
---
M tests/site_tests.py
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
XZise: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index b0b51f8..5bdb2d5 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -106,6 +106,9 @@
def test_siteinfo_normal_call(self):
"""Test calling the Siteinfo without setting
dump."""
+ if MediaWikiVersion(self.site.version()) < MediaWikiVersion('1.16'):
+ raise unittest.SkipTest('requires v1.16+')
+
old = self.site.siteinfo('general')
self.assertIn('time', old)
self.assertEqual(old, self.site.siteinfo['general'])
@@ -1979,10 +1982,17 @@
self.assertTrue(-12 * 60 <= mysite.siteinfo['timeoffset'] <= +14 *
60)
self.assertEqual(mysite.siteinfo['timeoffset'] % 15, 0)
self.assertRegex(mysite.siteinfo['timezone'],
"([A-Z]{3,4}|[A-Z][a-z]+/[A-Z][a-z]+)")
+ self.assertIn(mysite.siteinfo['case'], ["first-letter",
"case-sensitive"])
+
+ def test_siteinfo_v1_16(self):
+ """Test v.16+ siteinfo values."""
+ if MediaWikiVersion(self.site.version()) < MediaWikiVersion('1.16'):
+ raise unittest.SkipTest('requires v1.16+')
+
+ mysite = self.get_site()
self.assertIsInstance(
datetime.strptime(mysite.siteinfo['time'],
'%Y-%m-%dT%H:%M:%SZ'),
datetime)
- self.assertIn(mysite.siteinfo['case'], ["first-letter",
"case-sensitive"])
self.assertEqual(re.findall("\$1",
mysite.siteinfo['articlepath']), ["$1"])
def test_properties_with_defaults(self):
--
To view, visit
https://gerrit.wikimedia.org/r/246179
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I523b923c5fc672327c4a10748373335cb8385aa0
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>