jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/472523 ) Change subject: [bugfix] weblinkchecker.py: Don't call 'url', a unicode object ...................................................................... [bugfix] weblinkchecker.py: Don't call 'url', a unicode object Unicode objects are not callable. Regression from 482a453 Bug: T209094 Change-Id: I580f5f71648959523d769b3f379f8bd4d8129dea --- M scripts/weblinkchecker.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Framawiki: Looks good to me, approved D3r1ck01: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py index 1089399..18fd8d5 100755 --- a/scripts/weblinkchecker.py +++ b/scripts/weblinkchecker.py @@ -590,7 +590,7 @@ } # identification for debugging purposes self.setName(('{0} - {1}'.format(page.title(), - url().encode('utf-8', 'replace')))) + url.encode('utf-8', 'replace')))) self.HTTPignore = HTTPignore self._use_fake_user_agent = config.fake_user_agent_default.get( 'weblinkchecker', False) -- To view, visit https://gerrit.wikimedia.org/r/472523 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I580f5f71648959523d769b3f379f8bd4d8129dea Gerrit-Change-Number: 472523 Gerrit-PatchSet: 5 Gerrit-Owner: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Siebrand <siebrand(a)kitano.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: jenkins-bot (75)