jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused imports, methods and variables
......................................................................
Remove unused imports, methods and variables
The method load was copied from basic.py in the initial port from compat,
and is unused as the bot does page checking in treat().
Likewise import of config was copied from basic.py.
main() variable checkcurrent is set but was not used. Moved a block of code.
Change-Id: I97b83965bd08a8ce156634cea30841b0174a3ba7
---
M scripts/commonscat.py
1 file changed, 10 insertions(+), 24 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
Guoguo12: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/scripts/commonscat.py b/scripts/commonscat.py
index de28ab2..51c7dcc 100755
--- a/scripts/commonscat.py
+++ b/scripts/commonscat.py
@@ -67,7 +67,6 @@
import add_text
import pywikibot
-from pywikibot import config
from pywikibot import pagegenerators
docuReplacements = {
@@ -263,20 +262,6 @@
% page.title(asLink=True))
else:
self.addCommonscat(page)
-
- def load(self, page):
- """ Load the given page, do some changes, and save it.
"""
- try:
- text = page.get()
- except pywikibot.NoPage:
- pywikibot.output(u"Page %s does not exist; skipping."
- % page.title(asLink=True))
- except pywikibot.IsRedirectPage:
- pywikibot.output(u"Page %s is a redirect; skipping."
- % page.title(asLink=True))
- else:
- return text
- return None
def save(self, text, page, comment, minorEdit=True, botflag=True):
# only save if something was changed
@@ -572,20 +557,21 @@
summary = arg[9:]
elif arg.startswith('-checkcurrent'):
checkcurrent = True
- primaryCommonscat, commonscatAlternatives = \
- CommonscatBot.getCommonscatTemplate(
- pywikibot.Site().code)
- generator = pagegenerators.NamespaceFilterPageGenerator(
- pagegenerators.ReferringPageGenerator(
- pywikibot.Page(pywikibot.Site(),
- u'Template:' + primaryCommonscat),
- onlyTemplateInclusion=True), ns)
-
elif arg == '-always':
always = True
else:
genFactory.handleArg(arg)
+ if checkcurrent:
+ primaryCommonscat, commonscatAlternatives = \
+ CommonscatBot.getCommonscatTemplate(
+ pywikibot.Site().code)
+ generator = pagegenerators.NamespaceFilterPageGenerator(
+ pagegenerators.ReferringPageGenerator(
+ pywikibot.Page(pywikibot.Site(),
+ u'Template:' + primaryCommonscat),
+ onlyTemplateInclusion=True), ns)
+
if not generator:
generator = genFactory.getCombinedGenerator()
if not generator:
--
To view, visit
https://gerrit.wikimedia.org/r/141368
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97b83965bd08a8ce156634cea30841b0174a3ba7
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Guoguo12 <Guoguo12(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: devunt <devunt(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>