Hello PywikibotCommitWatcher,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/255702
to review the following change.
Change subject: Add jsonlint to grunt tasks ......................................................................
Add jsonlint to grunt tasks
Change-Id: Icccde811d30874e9bd25834876ca65a42aa39e89 --- M Gruntfile.js M package.json 2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/i18n refs/changes/02/255702/1
diff --git a/Gruntfile.js b/Gruntfile.js index 971ed9f..4b3fd44 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -5,14 +5,21 @@ /*jshint node:true */ module.exports = function ( grunt ) { grunt.loadNpmTasks( 'grunt-banana-checker' ); + grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.initConfig( { banana: { all: ['*/', '!node_modules/'] + }, + jsonlint: { + all: [ + '**/*.json', + '!node_modules/**' + ] } } );
- grunt.registerTask( 'lint', ['banana'] ); + grunt.registerTask( 'lint', ['jsonlint', 'banana'] ); grunt.registerTask( 'test', ['lint'] ); grunt.registerTask( 'default', ['test'] ); }; diff --git a/package.json b/package.json index 5387cac..1e42716 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "devDependencies": { "grunt": "0.4.2", "grunt-cli": "0.1.13", + "grunt-jsonlint": "1.0.6", "grunt-banana-checker": "0.2.2" } } -
Hashar has abandoned this change.
Change subject: Add jsonlint to grunt tasks ......................................................................
Abandoned
er Jayvdb , banana checker already parse the json files :-}
Legoktm has posted comments on this change.
Change subject: Add jsonlint to grunt tasks ......................................................................
Patch Set 1:
[07:05:30] <jayvdb> hashar: legoktm: re ^, doesnt banana checker include a json linter ? [09:18:06] <legoktm> jayvdb: technically it does, but the error messages from jsonlint are usually better I think [09:18:32] <legoktm> jayvdb: and depending on the settings, banana-checker will only read en.json and qqq.json
pywikibot-commits@lists.wikimedia.org