jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/384324 )
Change subject: [bugfix] Prevent nested error handing
......................................................................
[bugfix] Prevent nested error handing
Bug: T176297
Change-Id: I5d5b2be952946bc776249d87e892fd3c3fbb79d9
---
M tests/site_tests.py
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 3adc9ee..1b45692 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1487,11 +1487,12 @@
get_redirects=True, where='title'):
self.assertIsInstance(hit, pywikibot.Page)
self.assertEqual(hit.namespace(), 0)
- try:
- self.assertIn('wiki', hit.title().lower())
- except AssertionError:
- self.assertTrue(any('wiki' in r.title().lower() for r in
- hit.getReferences(redirectsOnly=True)))
+ if 'wiki' not in hit.title().lower():
+ self.assertTrue(
+ any('wiki' in r.title().lower()
+ for r in hit.getReferences(redirectsOnly=True)),
+ "'wiki' neither found in '{0}'.lower()
"
+ 'nor in its redirects'.format(hit.title()))
except pywikibot.data.api.APIError as e:
if e.code in ('search-title-disabled',
'gsrsearch-title-disabled'):
raise unittest.SkipTest(
--
To view, visit
https://gerrit.wikimedia.org/r/384324
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d5b2be952946bc776249d87e892fd3c3fbb79d9
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>