jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1330566?usp=email )
Change subject: pagegenerators: Use removesuffix for schema names ......................................................................
pagegenerators: Use removesuffix for schema names
Normalize Superset schema names with str.removesuffix instead of invoking the regular expression engine for each value.
Change-Id: Idd30da797ba3d136e9b35c65744e1d2936ab3dc0 --- M pywikibot/pagegenerators/_generators.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved
diff --git a/pywikibot/pagegenerators/_generators.py b/pywikibot/pagegenerators/_generators.py index 5eb3f45..3ae65d8 100644 --- a/pywikibot/pagegenerators/_generators.py +++ b/pywikibot/pagegenerators/_generators.py @@ -1148,14 +1148,14 @@ if not schema_name: raise TypeError('Schema name or site must be provided.')
- wikidb = re.sub('_p$', '', schema_name) + wikidb = schema_name.removesuffix('_p') site = pywikibot.site.APISite.fromDBName(wikidb)
for row in rows: # If page_wikidb column in SQL result then use it to retrieve site if 'page_wikidb' in row: # remove "_p" suffix - wikidb = re.sub('_p$', '', row['page_wikidb']) + wikidb = row['page_wikidb'].removesuffix('_p')
# Caching sites if wikidb not in sites:
pywikibot-commits@lists.wikimedia.org