jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/509360 )
Change subject: [cleanup] use setUpModule to skipping tests ......................................................................
[cleanup] use setUpModule to skipping tests
Change-Id: I1ae3035d6aba82dd0af43dca94098009749cb8bd --- M tests/tk_tests.py 1 file changed, 6 insertions(+), 14 deletions(-)
Approvals: Dvorapa: Looks good to me, but someone else must approve Zhuyifei1999: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/tk_tests.py b/tests/tk_tests.py index 844d238..c713f50 100644 --- a/tests/tk_tests.py +++ b/tests/tk_tests.py @@ -28,13 +28,6 @@
net = True
- @classmethod - def setUpClass(cls): - """Set up test class.""" - if os.environ.get('PYWIKIBOT_TEST_GUI', '0') != '1': - raise unittest.SkipTest('Tkdialog tests are disabled on Travis-CI') - super(TestTkdialog, cls).setUpClass() - def testTkdialog(self): """Test Tk dialog.""" try: @@ -50,13 +43,6 @@
net = True
- @classmethod - def setUpClass(cls): - """Set up test class.""" - if os.environ.get('PYWIKIBOT_TEST_GUI', '0') != '1': - raise unittest.SkipTest('Tkinter tests are disabled on Travis-CI') - super(TestTkinter, cls).setUpClass() - def testTkinter(self): """Test Tkinter window.""" root = tkinter.Tk() @@ -70,6 +56,12 @@ assert v is None
+def setUpModule(): # noqa: N802 + """Skip Travis tests if PYWIKIBOT_TEST_GUI variable is not set.""" + if os.environ.get('PYWIKIBOT_TEST_GUI', '0') != '1': + raise unittest.SkipTest('Tkinter tests are disabled on Travis-CI') + + if __name__ == '__main__': # pragma: no cover try: unittest.main()
pywikibot-commits@lists.wikimedia.org