jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/485485 ) Change subject: [tests] Skip test_pages_with_property_generator test for wikia ...................................................................... [tests] Skip test_pages_with_property_generator test for wikia wikia has mw version 1.19 but 1.21+ is needed for Propery generator. Skip this test for wikia. Bug: T214009 Change-Id: I3cef33a0b11a170c700b187aa791a5cbd411cf98 --- M tests/pagegenerators_tests.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: D3r1ck01: Looks good to me, but someone else must approve Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 57b1e15..110c769 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -2,7 +2,7 @@ # -*- coding: utf-8 -*- """Test pagegenerators module.""" # -# (C) Pywikibot team, 2009-2018 +# (C) Pywikibot team, 2009-2019 # # Distributed under the terms of the MIT license. from __future__ import absolute_import, division, unicode_literals @@ -1135,6 +1135,8 @@ def test_pages_with_property_generator(self): """Test the pages_with_property_generator method.""" mysite = self.get_site() + if mysite.mw_version < '1.21': + raise unittest.SkipTest('requires v1.21+') for item in ('defaultsort', 'disambiguation', 'displaytitle', 'hiddencat', 'invalid_property'): if item in mysite.get_property_names(): -- To view, visit https://gerrit.wikimedia.org/r/485485 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3cef33a0b11a170c700b187aa791a5cbd411cf98 Gerrit-Change-Number: 485485 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: D3r1ck01 &lt;alangiderick(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Framawiki &lt;framawiki(a)tools.wmflabs.org&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot (75) Gerrit-CC: Dvorapa &lt;dvorapa(a)seznam.cz&gt;