jenkins-bot has submitted this change and it was merged. Change subject: [FEAT] plural_tests: Verify plural rules ...................................................................... [FEAT] plural_tests: Verify plural rules This verifies the consistency of all plural rules. Static plural rules must have `nplurals` set to 1 and return 0 for `plural`. If the plural is a callable it'll test all values from 0 until `max_num` and check that the indexes returned are greater than 0 but also below the number of plurals. That maximum number thus must then cover all possible plurals for all languages. Change-Id: If2a665fa047630de30ac51a108144affb08afa16 --- M tests/__init__.py A tests/plural_tests.py 2 files changed, 76 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/__init__.py b/tests/__init__.py index 7a93711..5f3b16e 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -71,6 +71,7 @@ library_test_modules = [ 'python', + 'plural', 'deprecation', 'ui', 'ui_options', diff --git a/tests/plural_tests.py b/tests/plural_tests.py new file mode 100644 index 0000000..dc1a2c1 --- /dev/null +++ b/tests/plural_tests.py @@ -0,0 +1,75 @@ +# -*- coding: utf-8 -*- +"""Test plural module.""" +# +# (C) Pywikibot team, 2015 +# +# Distributed under the terms of the MIT license. +# +from __future__ import absolute_import, unicode_literals + +__version__ = '$Id$' + +from pywikibot import plural + +from tests.aspects import ( + unittest, TestCase, MetaTestCaseClass, +) +from tests.utils import add_metaclass + + +class MetaPluralRulesTest(MetaTestCaseClass): + + """Metaclass to test each plural rule in separate tests.""" + + def __new__(cls, name, bases, dct): + """Create a new test case which tests all plural rules.""" + def create_test(rule): + def test_static_rule(self): + """Test a rule which is just one integer.""" + self.assertEqual(rule['nplurals'], 1) + self.assertEqual(rule['plural'], 0) + + def test_callable_rule(self): + """Test a rule which is callable.""" + # in theory a static rule could be also callable + self.assertGreater(rule['nplurals'], 0) + num_plurals = set() + for num in range(self.max_num + 1): + index = rule['plural'](num) + self.assertLess(index, rule['nplurals'], + msg='Plural for {0} created an index {1} ' + '(greater than {2})'.format(num, index, + rule['nplurals'])) + num_plurals.add(index) + self.assertCountEqual(num_plurals, list(range(rule['nplurals']))) + + # Don't already fail on creation + if callable(rule.get('plural')): + return test_callable_rule + else: + return test_static_rule + + for lang, rule in plural.plural_rules.items(): + cls.add_method(dct, 'test_{0}'.format(lang), create_test(rule), + doc_suffix='for "{0}"'.format(lang)) + return super(MetaPluralRulesTest, cls).__new__(cls, name, bases, dct) + + +@add_metaclass +class TestPluralRules(TestCase): + + """Test the consistency of the plural rules.""" + + __metaclass__ = MetaPluralRulesTest + + net = False + # for callable plural rules it'll test up until this number, this number + # must cause to create all plurals in all dynamic languages + max_num = 1000 + + +if __name__ == '__main__': + try: + unittest.main() + except SystemExit: + pass -- To view, visit https://gerrit.wikimedia.org/r/244967 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2a665fa047630de30ac51a108144affb08afa16 Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Siebrand &lt;siebrand(a)kitano.nl&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>