jenkins-bot has submitted this change and it was merged.
Change subject: Add explanations for ignored flake8 codes
......................................................................
Add explanations for ignored flake8 codes
Change-Id: I6406b03d0e4c5af9a15fd05eb958070877755bed
---
M tox.ini
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tox.ini b/tox.ini
index ac5a94b..b737fee 100644
--- a/tox.ini
+++ b/tox.ini
@@ -78,6 +78,25 @@
-rdocs/requirements-py3.txt
[flake8]
+# The following are intentionally ignored, possibly pending consensus
+# D105: Missing docstring in magic method
+# D211: No blank lines allowed before class docstring
+# FI10,FI12,FI13,FI15: __future__ import "division",
"with_statement", "print_function" and "generator_stop"
missing
+# FI5: __future__ import "x" present
+# H101: TODO format
+# H236: Mandatory use of six for Python 2 & 3 metaclass support
+# H404: docstring multiline start
+# H405: docstring summary line
+# H301,I100,I101: import order rules; Pywikibot uses rules H306 and I201
+
+# The following are to be fixed
+# D102: Missing docstring in public method
+# D103: Missing docstring in public function
+# E402: module level import not at top of file; see T87409
+# E731: do not assign a lambda expression, use a def; see I7b3db838
+# H201: Except: format
+# H202: assertRaises Exception too broad
+# P102,P103: string does contain unindexed parameters; see I36355923
ignore =
E402,E731,D105,D211,FI10,FI12,FI13,FI15,FI5,H101,H201,H202,H236,H301,H404,H405,I100,I101,P102,P103
exclude = .tox,.git,./*.egg,ez_setup.py,build,externals,user-config.py,./scripts/i18n/*
max_line_length = 130
@@ -97,9 +116,11 @@
scripts/catall.py,scripts/imageharvest.py,scripts/makecat.py,scripts/maintenance/cache.py,scripts/maintenance/wikimedia_sites.py
: +D103
[pep8]
+# see explanations above
ignore = E402,E731
exclude = .tox,.git,./*.egg,ez_setup.py,build,externals,user-config.py,./scripts/i18n/*
max_line_length = 130
[pep257]
+# see explanations above
ignore = D105,D211
--
To view, visit
https://gerrit.wikimedia.org/r/247077
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6406b03d0e4c5af9a15fd05eb958070877755bed
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>