jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/523169 ) Change subject: test(TestLoginLogout): mark as a user test ...................................................................... test(TestLoginLogout): mark as a user test Also remove the initial login status check. RequireUserMixin will login to the site automatically. Bug: T228050 Change-Id: Idef0964eda365aaabd48433ee58aeb37f98ef296 --- M tests/site_tests.py 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/site_tests.py b/tests/site_tests.py index e94296e..beed649 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -3660,17 +3660,13 @@ """Test for login and logout methods.""" - @unittest.skipIf(os.environ.get('APPVEYOR', 'false') in ('true', 'True'), - 'No user defined for APPVEYOR tests') + user = True + def test_login_logout(self): """Validate login and logout methods by toggling the state.""" site = self.get_site() loginstatus = pywikibot.site.LoginStatus - self.assertFalse(site.logged_in()) - self.assertEqual(site._loginstatus, loginstatus.NOT_ATTEMPTED) - - site.login() self.assertTrue(site.logged_in()) self.assertIn(site._loginstatus, (loginstatus.IN_PROGRESS, loginstatus.AS_USER)) -- To view, visit https://gerrit.wikimedia.org/r/523169 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idef0964eda365aaabd48433ee58aeb37f98ef296 Gerrit-Change-Number: 523169 Gerrit-PatchSet: 2 Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)