jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/608690 ) Change subject: [tests] Remove failing test_ASCII_compatible test ...................................................................... [tests] Remove failing test_ASCII_compatible test - remove failing page_tests.TestPageRepr.test_ASCII_compatible because Python 2 has been dropped and this issue will not be solved. No need to test this known bug anymore Bug: T130919 Bug: T66958 Change-Id: I94e168d07b3e1fb05e2d2a09d6a72949ffe22939 --- M tests/page_tests.py 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: DannyS712: Looks good to me, but someone else must approve Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/page_tests.py b/tests/page_tests.py index 09eb93c..8a3ccbb 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -753,14 +753,6 @@ self.assertEqual('%r' % self.page, "Page('Ō')") self.assertEqual('{0!r}'.format(self.page), "Page('Ō')") - @unittest.skipIf(not PY2, 'Python 2 specific test') - @unittest.expectedFailure - def test_ASCII_compatible(self): - """Test that repr returns ASCII compatible bytes in Python 2.""" - page = pywikibot.Page(self.site, 'ä') - # Bug T95809, the repr in Python 2 should be decodable as ASCII - repr(page).decode('ascii') - class TestPageReprASCII(TestPageBaseUnicode): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/608690 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I94e168d07b3e1fb05e2d2a09d6a72949ffe22939 Gerrit-Change-Number: 608690 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: DannyS712 <DannyS712.enwiki(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged