jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/671623 ) Change subject: [tests] test archivebot.DiscussuionPage.is_full() method ...................................................................... [tests] test archivebot.DiscussuionPage.is_full() method - add tests for DiscussuionPage.is_full() method - simplify TestDiscussionPageObject tests Change-Id: Iaa9b82b32bc88043cfe6d445bf70b41e1e1a5cc6 --- M tests/archivebot_tests.py 1 file changed, 31 insertions(+), 16 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/archivebot_tests.py b/tests/archivebot_tests.py index 3314892..1cf39d1 100644 --- a/tests/archivebot_tests.py +++ b/tests/archivebot_tests.py @@ -239,6 +239,15 @@ family = 'wikipedia' code = 'test' + def load_page(self, title: str): + """Load the given page.""" + page = pywikibot.Page(self.site, title) + tmpl = pywikibot.Page(self.site, 'User:MiszaBot/config') + archiver = archivebot.PageArchiver(page=page, template=tmpl, salt='') + page = archivebot.DiscussionPage(page, archiver) + page.load_page() + self.page = page + def testTwoThreadsWithCommentedOutThread(self): """Test recognizing two threads and ignoring a commented out thread. @@ -258,14 +267,8 @@ == B == foo bar bar bar """ - site = self.get_site() - page = pywikibot.Page(site, 'Talk:For-pywikibot-archivebot') - tmpl = pywikibot.Page(site, 'User:MiszaBot/config') - archiver = archivebot.PageArchiver( - page=page, template=tmpl, salt='', force=False) - page = archivebot.DiscussionPage(page, archiver) - page.load_page() - self.assertEqual([x.title for x in page.threads], ['A', 'B']) + self.load_page('Talk:For-pywikibot-archivebot') + self.assertEqual([x.title for x in self.page.threads], ['A', 'B']) def testThreadsWithSubsections(self): """Test recognizing threads with subsections. @@ -287,14 +290,26 @@ == B == foo bar bar bar """ - site = self.get_site() - page = pywikibot.Page(site, 'Talk:For-pywikibot-archivebot/testcase2') - tmpl = pywikibot.Page(site, 'User:MiszaBot/config') - archiver = archivebot.PageArchiver( - page=page, template=tmpl, salt='', force=False) - page = archivebot.DiscussionPage(page, archiver) - page.load_page() - self.assertEqual([x.title for x in page.threads], ['A', 'B']) + self.load_page('Talk:For-pywikibot-archivebot/testcase2') + self.assertEqual([x.title for x in self.page.threads], ['A', 'B']) + + def test_is_full_method(self): + """Test DiscussionPage.is_full method.""" + self.load_page('Talk:For-pywikibot-archivebot') + page = self.page + self.assertEqual(page.archiver.maxsize, 2096128) + self.assertEqual(page.size(), 181) + self.assertTrue(page.is_full((100, 'B'))) + page.full = False + self.assertFalse(page.is_full((1000, 'B'))) + page.full = False + self.assertFalse(page.is_full((3, 'T'))) + page.full = False + self.assertTrue(page.is_full((2, 'T'))) + self.assertTrue(page.is_full((3, 'T'))) # page.full is kept + page.full = False + page.archiver.maxsize = 100 + self.assertTrue(page.is_full((1000, 'B'))) # maxsize is used class TestPageArchiverObject(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/671623 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Iaa9b82b32bc88043cfe6d445bf70b41e1e1a5cc6 Gerrit-Change-Number: 671623 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged